Update patch.py #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support patching of both import forms: - The existing `from ... import ... as ...` - The new `import ... as ...`
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
- Coverage 93.51% 93.35% -0.16%
==========================================
Files 12 12
Lines 524 527 +3
==========================================
+ Hits 490 492 +2
- Misses 34 35 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The regex at
protobuf_gen/patch.py::rename_protobuf_importsonly replaces imports in the form offrom ... import ... as ....My protobuf-compiler generates imports in the form of
import ... as ....What do you think?