Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replaced github.com/pkg/errors with errors #460

Merged
merged 1 commit into from
Aug 21, 2022
Merged

refactor: Replaced github.com/pkg/errors with errors #460

merged 1 commit into from
Aug 21, 2022

Conversation

Fank
Copy link
Contributor

@Fank Fank commented May 31, 2022

Description

Please describe what does this Pull Request fix or add?.

It replaces the obsolete module github.com/pkg/errors with the official one errors which got introduced in golang 1.13

Information that is useful here:

  • The What: What is your change doing?
  • The Why: Why is your change useful/needed? What is your use case? (this helps us to understand the real world better)
  • Type of change: Things like Bugfix, New feature, Code quality improvements, Dependency upgrade, Documentation, ...

Code quality improvements

  • Breaking change: Yes or no? Backward compatible?

No

  • Related to an issue: Does this fix or close an issue? Or is related in any kind?
  • Jira Version + Type: Which Jira version and type (on-premise / cloud) you have used?

Cloud

Example:

Let us know how users can use or test this functionality.

// Example code

Checklist

@andygrunwald
Copy link
Owner

Thank you @Fank!
I have limited time at the moment, hence my review will take a while.

Would you mind checking the tests in the meantime? That would be very nice!

@Fank
Copy link
Contributor Author

Fank commented Jun 7, 2022

Should be fixed now

@andygrunwald
Copy link
Owner

FYI: #478

@andygrunwald
Copy link
Owner

Hey,

I am very sorry that this pull request has been open for a long time with no final feedback or merge/decline. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma.

However, there is news: We are kicking off v2 of this library 🚀

To provide visibility, we created the Road to v2 Milestone and calling for your feedback in #489

The development will take some time; however, I hope you can benefit from the changes.
If you seek priority development for your pull request + you like to sponsor it, please contact me.

What does this mean for my pull request?

We will work on this pull request indirectly.
We might merge it during the development or pull parts of it into the new version.
This means that during the development phase, we aim to tackle it.
Maybe in a different way like it is currently handled.
Please understand that this will take a while because we are running this in our spare time.

Final words

Thanks for using and contributing to this library.
If there is anything else you would like to tell us, let us know!

@andygrunwald
Copy link
Owner

This change is related to #478

@andygrunwald
Copy link
Owner

I like this change. Thanks a lot @Fank!

This will go directly into v2

@andygrunwald andygrunwald merged commit c6e6022 into andygrunwald:main Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants