feat: ui flow for offline sharing #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan <hey@janrietveld.com>
TimoGlastra
approved these changes
Nov 20, 2024
apps/easypid/src/app/(app)/notifications/offlinePresentation.tsx
Outdated
Show resolved
Hide resolved
| pushToOfflinePresentation({ | ||
| sessionTranscript: Buffer.from(data.sessionTranscript).toString('base64'), | ||
| deviceRequest: Buffer.from(data.deviceRequest).toString('base64'), | ||
| requestedAttributes: Object.entries(requestedNamespace).map(([key]) => key), |
There was a problem hiding this comment.
do we only handle the requested namespaces (not attributes within?)
There was a problem hiding this comment.
It takes the requestedNamespace which is equal to the pid, and in there are the attributes requested.
| credentialDataHandlerOptions?: CredentialDataHandlerOptions | ||
| } | ||
|
|
||
| export function FunkeQrScannerScreen({ credentialDataHandlerOptions }: QrScannerScreenProps) { |
There was a problem hiding this comment.
it's sort of ok with the deadline now, but i think it would have been better to split this into a generic scan/show component that can be used in both paradym and easypid and then add a showQrCode and exrract all the mdoc specific logic out of here.
apps/easypid/src/features/share/slides/ShareCredentialsSlide.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one issue when you leave and come back again the QR code is sometimes invalid. I dont know if this is because i'm on a dev server or not, so we should see if this works when released.
Here is a video of the flow (with fake data on iPhone, but i can't nicely record on Android).
ScreenRecording_11-19-2024.11-23-24_1.1.MP4