feat: improvements to the issue/share flows #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan <hey@janrietveld.com>
janrtvld
commented
Nov 21, 2024
| onGoToWallet: () => void | ||
| } | ||
|
|
||
| export const CredentialRetrievalSlide = ({ display, isCompleted, onGoToWallet }: CredentialRetrievalSlideProps) => { | ||
| const { completeProgressBar } = useWizard() | ||
| export const CredentialRetrievalSlide = ({ |
There was a problem hiding this comment.
I know this file is a bit of a mess with all the states so I'm thinking about better abstractions for the animations.
But will prob be after the deadline
TimoGlastra
reviewed
Nov 21, 2024
| case 'pin': | ||
| return { | ||
| title: 'Card offered', | ||
| subtitle: `To receive this card from ${issuerName}, you need to enter your PIN.`, |
There was a problem hiding this comment.
I think it's good to keep it as a transaction PIN or something, to not confuse with other PINs used?
Suggested change
| subtitle: `To receive this card from ${issuerName}, you need to enter your PIN.`, | |
| subtitle: `To receive this card from ${issuerName}, you need to enter a transaction PIN.`, |
TimoGlastra
reviewed
Nov 21, 2024
Comment on lines
14
to
15
| title: 'Share who you are', | ||
| subtitle: `To receive this card from ${issuerName}, you need to share your identity.`, |
There was a problem hiding this comment.
It's not neccesarily that you share who you are. Maybe you'll need to share something about your dog, who knows.
cc @anagoessens feel free to make suggestions here.
Suggested change
| title: 'Share who you are', | |
| subtitle: `To receive this card from ${issuerName}, you need to share your identity.`, | |
| title: 'Sharing required', | |
| subtitle: `To receive this card from ${issuerName}, you need to share existing cards in your wallet.`, |
TimoGlastra
reviewed
Nov 21, 2024
| default: | ||
| return { | ||
| title: 'Card offered', | ||
| subtitle: `${issuerName} wants to give you the following card:`, |
There was a problem hiding this comment.
give is maybe not hte right word, is issue too technical?
Suggested change
| subtitle: `${issuerName} wants to give you the following card:`, | |
| subtitle: `${issuerName} wants to issue you the following card:`, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback still welcome. The text will probably also still change.
ScreenRecording_11-21-2024.17-00-44_1.MP4