Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webpack-dev-server options #5276

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Fix webpack-dev-server options #5276

merged 2 commits into from
Oct 15, 2024

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Oct 15, 2024

Bump @redhat-cloud-services/frontend-components-config-utilities from 3.2.2 to 3.2.3 switched from using onBeforeSetupMiddleware to setupMiddlewares (RedHatInsights/frontend-components#2070)

so we don't need that fix anymore,
but it was also removing devServer.https, which is still used, deleting as before, with fixed condition.

(stable branches are not affected, no frontend-components-config)

Bump @redhat-cloud-services/frontend-components-config-utilities from 3.2.2 to 3.2.3
switched from using `onBeforeSetupMiddleware` to `setupMiddlewares`

so we don't need that fix anymore,
but it was also removing devServer.https, which is still used,
deleting as before, with fixed condition.
@himdel
Copy link
Collaborator Author

himdel commented Oct 15, 2024

Merging to get dev env working again.

@himdel himdel merged commit 4da157b into ansible:master Oct 15, 2024
8 of 12 checks passed
@himdel himdel deleted the fix-dev branch October 15, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant