Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics dispatcher callback receiver swaparoo #15615

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Metrics dispatcher callback receiver swaparoo #15615

merged 1 commit into from
Nov 8, 2024

Conversation

chrismeyersfsu
Copy link
Member

SUMMARY

Programmer typo error.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
AWX VERSION
devel
ADDITIONAL INFORMATION

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

AlanCoding
AlanCoding approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@AlanCoding AlanCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems concerning that this never seemed to matter...

@chrismeyersfsu
Copy link
Member Author

At first glance, yes. But at this time nothing calls these per service http metric endpoints.

@chrismeyersfsu chrismeyersfsu merged commit d388f91 into devel Nov 8, 2024
20 of 26 checks passed
@chrismeyersfsu chrismeyersfsu deleted the fix-metrics-typo branch November 8, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanCoding AlanCoding AlanCoding approved these changes

Assignees
No one assigned
Labels
component:api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrismeyersfsu @AlanCoding