-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove level from doc-style action #545
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Can't we wait to see what the vale maintainer decides? I wouldn't want to duplicate efforts on this. |
Agreed. Let's leave this in draft for the moment until Vale and Reviewdog take a final decission. Thanks for noticing this unused input parameter, Sebastien. |
I'll work on |
What's the status here @SMoraisAnsys? |
I didn't have time to work on the vale action and probably won't be able to work on it next week either. If you want to handle the vale action modification, please do so. |
While asking for an update in
vale-action
, I discovered thatlevel
is no longer an input of this action, see errata-ai/vale-action@c4213d4.I've opened an issue to update the version of
reviewdog
invale-action
. If this occurs,vale-action
could leverage the new featurefail-level
which could lead tolevel
being added back. However, this is just an issue and I don't know what the maintainer will decide, see errata-ai/vale-action#131 for more information.In the mean time, I propose we remove this misleading input which gave me the impression that we could chose the level on which the action will fail.