Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove level from doc-style action #545

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SMoraisAnsys
Copy link
Contributor

While asking for an update in vale-action, I discovered that level is no longer an input of this action, see errata-ai/vale-action@c4213d4.

I've opened an issue to update the version of reviewdog in vale-action. If this occurs, vale-action could leverage the new feature fail-level which could lead to level being added back. However, this is just an issue and I don't know what the maintainer will decide, see errata-ai/vale-action#131 for more information.

In the mean time, I propose we remove this misleading input which gave me the impression that we could chose the level on which the action will fail.

@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner August 21, 2024 10:54
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@RobPasMue
Copy link
Member

Can't we wait to see what the vale maintainer decides? I wouldn't want to duplicate efforts on this.

@jorgepiloto
Copy link
Member

Can't we wait to see what the vale maintainer decides? I wouldn't want to duplicate efforts on this.

Agreed. Let's leave this in draft for the moment until Vale and Reviewdog take a final decission.

Thanks for noticing this unused input parameter, Sebastien.

@SMoraisAnsys
Copy link
Contributor Author

Can't we wait to see what the vale maintainer decides? I wouldn't want to duplicate efforts on this.

Agreed. Let's leave this in draft for the moment until Vale and Reviewdog take a final decission.

Thanks for noticing this unused input parameter, Sebastien.

I'll work on vale-action to add this feature. The maintainer doesn't seem to be opposed to adding a fail-level !

@SMoraisAnsys SMoraisAnsys marked this pull request as draft September 3, 2024 07:28
@RobPasMue
Copy link
Member

What's the status here @SMoraisAnsys?

@SMoraisAnsys
Copy link
Contributor Author

What's the status here @SMoraisAnsys?

I didn't have time to work on the vale action and probably won't be able to work on it next week either. If you want to handle the vale action modification, please do so.

@RobPasMue RobPasMue changed the title refactor: remove level from code-style action refactor: remove level from doc-style action Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants