Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding attrs to ignored packages #658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

germa89
Copy link
Contributor

@germa89 germa89 commented Dec 16, 2024

For some reason, attrs license is not detected, however, it is MIT license:

https://github.com/python-attrs/attrs

This was highlighted here:

https://github.com/ansys/pymapdl/actions/runs/12349513107/job/34460488022?pr=3569#step:2:5561

@germa89 germa89 self-assigned this Dec 16, 2024
@germa89 germa89 requested a review from a team as a code owner December 16, 2024 09:45
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement General improvements to existing features label Dec 16, 2024
@RobPasMue
Copy link
Member

RobPasMue commented Dec 16, 2024

That's because somebody complained and they did it recently: see python-attrs/attrs#1377

Somebody has already let them know.. ehem ehem @SMoraisAnsys - see python-attrs/attrs#1386
Thanks a lot @SMoraisAnsys for bringing it to their attention

EDIT: looks like you were pulling the latest version already... the attrs project is doing things fine. The problem might be related to PyPI... they should also add the metadata classifiers manually IMO.

Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend waiting for changes in attrs.

Depending on the changes performed we could still make things work on our sides thanks to the option --from=mixed of pip-licenses which leverages both Trove classifier (which we could exploit) and package metadata (which we can no longer retrieve). From what I understand of the exchanges I've read it's something related to the new metadata fields added in metadata version 2.4 (which is used by hatch).

image

@germa89
Copy link
Contributor Author

germa89 commented Dec 17, 2024

I would recommend waiting for changes in attrs.

Depending on the changes performed we could still make things work on our sides thanks to the option --from=mixed of pip-licenses which leverages both Trove classifier (which we could exploit) and package metadata (which we can no longer retrieve). From what I understand of the exchanges I've read it's something related to the new metadata fields added in metadata version 2.4 (which is used by hatch).

image

I'm not very fond of waiting many days... I cannot have many PR waiting for a dependency license check. If there is no progress by lunch time, I will do something on PyMAPDL as a temporal fix while they fix this.

@RobPasMue
Copy link
Member

RobPasMue commented Dec 17, 2024

I'm not very fond of waiting many days... I cannot have many PR waiting for a dependency license check. If there is no progress by lunch time, I will do something on PyMAPDL as a temporal fix while they fix this.

You've got several options:

@RobPasMue
Copy link
Member

Just remember to revert it once it's fixed ;)

@germa89
Copy link
Contributor Author

germa89 commented Dec 17, 2024

Just remember to revert it once it's fixed ;)

I will!! Thank you! :)

@germa89
Copy link
Contributor Author

germa89 commented Dec 18, 2024

A few packages are going to implement this temporary patch... maybe we should just done it here and take care of removing it later... xD

@SMoraisAnsys
Copy link
Contributor

Things seem to be moving "quite fast" and we shouldn't have to wait too much (see python-attrs/attrs#1386 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants