-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding attrs
to ignored packages
#658
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
That's because somebody complained and they did it recently: see python-attrs/attrs#1377 Somebody has already let them know.. ehem ehem @SMoraisAnsys - see python-attrs/attrs#1386 EDIT: looks like you were pulling the latest version already... the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend waiting for changes in attrs
.
Depending on the changes performed we could still make things work on our sides thanks to the option --from=mixed
of pip-licenses
which leverages both Trove classifier (which we could exploit) and package metadata (which we can no longer retrieve). From what I understand of the exchanges I've read it's something related to the new metadata fields added in metadata version 2.4 (which is used by hatch).
I'm not very fond of waiting many days... I cannot have many PR waiting for a dependency license check. If there is no progress by lunch time, I will do something on PyMAPDL as a temporal fix while they fix this. |
You've got several options:
|
Just remember to revert it once it's fixed ;) |
I will!! Thank you! :) |
A few packages are going to implement this temporary patch... maybe we should just done it here and take care of removing it later... xD |
Things seem to be moving "quite fast" and we shouldn't have to wait too much (see python-attrs/attrs#1386 (comment)) |
For some reason,
attrs
license is not detected, however, it is MIT license:https://github.com/python-attrs/attrs
This was highlighted here:
https://github.com/ansys/pymapdl/actions/runs/12349513107/job/34460488022?pr=3569#step:2:5561