-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Common library migration #254
Conversation
# Conflicts: # pyproject.toml
Remove Huygens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Samuelopez-ansys This PR is so big that it is a slog to review doc content in the last third of the changed files. The big items to note is that we have to use the "product name" consistently in all references. This is definitely not the case currently. If you provide me with the proper "product name" for each part of this package, I can do the updates for you in a separate PR. It looks like they should now be AEDT Antenna Toolkit and AEDT Wizard, but I would like you to confirm. Once this PR is merged, let me know and I will do an overall doc review.
@PipKat Thank you for your review. You are right, the product name is: And when the documentation refers to the user interface: Tomorrow we will merge this PR (after committing your suggestions) and then you can create a new PR, I will let you know. Thank you! |
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
No description provided.