Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Common library migration #254

Merged
merged 93 commits into from
May 6, 2024
Merged

Conversation

Samuelopez-ansys
Copy link
Member

No description provided.

doc/source/toolkit/ui.rst Outdated Show resolved Hide resolved
doc/source/toolkit/ui.rst Outdated Show resolved Hide resolved
doc/source/toolkit/ui.rst Outdated Show resolved Hide resolved
doc/source/toolkit/ui.rst Outdated Show resolved Hide resolved
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Samuelopez-ansys This PR is so big that it is a slog to review doc content in the last third of the changed files. The big items to note is that we have to use the "product name" consistently in all references. This is definitely not the case currently. If you provide me with the proper "product name" for each part of this package, I can do the updates for you in a separate PR. It looks like they should now be AEDT Antenna Toolkit and AEDT Wizard, but I would like you to confirm. Once this PR is merged, let me know and I will do an overall doc review.

@Samuelopez-ansys
Copy link
Member Author

@PipKat Thank you for your review.

You are right, the product name is:
AEDT Antenna Toolkit

And when the documentation refers to the user interface:
Antenna Wizard

Tomorrow we will merge this PR (after committing your suggestions) and then you can create a new PR, I will let you know.

Thank you!

SMoraisAnsys
SMoraisAnsys previously approved these changes Apr 30, 2024
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) May 6, 2024 12:39
@SMoraisAnsys SMoraisAnsys merged commit bd2e8d6 into main May 6, 2024
20 of 21 checks passed
@SMoraisAnsys SMoraisAnsys deleted the maint/common_library_migration branch May 6, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants