Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get trace data #297

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Fix get trace data #297

merged 2 commits into from
Nov 4, 2024

Conversation

Samuelopez-ansys
Copy link
Member

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Nov 4, 2024
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) November 4, 2024 09:38
SMoraisAnsys
SMoraisAnsys previously approved these changes Nov 4, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just wondering why do you need to test data ? Wouldn't it be better to check that the argument to be passed to __plot_2d_cut is not None instead of checking inside of the method ? Which case scenario leads to not data being empty ?

@Samuelopez-ansys
Copy link
Member Author

@SMoraisAnsys I applied your suggestion.

Checking if data is not empty is safer because sometimes AEDT could crash or disconnect when the data is being retrieved.

@Samuelopez-ansys Samuelopez-ansys merged commit 413458c into main Nov 4, 2024
17 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/issue_plot branch November 4, 2024 10:28
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.65%. Comparing base (f94c847) to head (3a42984).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files          12       12           
  Lines        3262     3262           
=======================================
  Hits         2892     2892           
  Misses        370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants