Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: VSin, ISin Sources added to Maxwell Circuit Primitives #5283

Open
wants to merge 38 commits into
base: main
Choose a base branch
from

Commits on Oct 11, 2024

  1. VSin, ISin Sources added to Maxwell Circuit Primitives

    Create Page and Select Page added to Circuit Primitives
    DaveTwyman committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5aac760 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f8699a5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8552947 View commit details
    Browse the repository at this point in the history
  4. VSin, ISin Sources added to Maxwell Circuit Primitives

    Create Page and Select Page added to Circuit Primitives
    DaveTwyman committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    93375bd View commit details
    Browse the repository at this point in the history
  5. Merge remote-tracking branch 'origin/5282-Add-Missing-Circuit-Element…

    …s' into 5282-Add-Missing-Circuit-Elements
    
    # Conflicts:
    #	src/ansys/aedt/core/modeler/circuits/primitives_circuit.py
    DaveTwyman committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    955bcf7 View commit details
    Browse the repository at this point in the history
  6. VSin, ISin Sources added to Maxwell Circuit Primitives

    Create Page and Select Page added to Circuit Primitives
    DaveTwyman committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    cf6153e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    eb4c79e View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. vsin, isin Sources added to Maxwell Circuit Primitives

    Create Page added to Circuit Primitives
    DaveTwyman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a07645f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    84e4f7a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d7945da View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a3a2340 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Configuration menu
    Copy the full SHA
    46152e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    bf84832 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Configuration menu
    Copy the full SHA
    0c4d246 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d180ad8 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Replaced id with comp_name

    Renamed create_vsin and create_isin to create_v_sin and create_i_sin
    DaveTwyman committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5a95e4e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4b7d09f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f00f682 View commit details
    Browse the repository at this point in the history
  4. Added support for Name=None case which previously created error messa…

    …ges. All elements now support names that are Strings, Integers, Floats or left blank as per expected Maxwell circuit schematic usage.
    DaveTwyman committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    359f752 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fdf3786 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Configuration menu
    Copy the full SHA
    4ef9e9f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d44fd5d View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Update src/ansys/aedt/core/modeler/circuits/primitives_circuit.py

    Co-authored-by: gmalinve <103059376+gmalinve@users.noreply.github.com>
    DaveTwyman and gmalinve authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0a98ed1 View commit details
    Browse the repository at this point in the history
  2. Update src/ansys/aedt/core/modeler/circuits/primitives_circuit.py

    Co-authored-by: gmalinve <103059376+gmalinve@users.noreply.github.com>
    DaveTwyman and gmalinve authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a4dd34f View commit details
    Browse the repository at this point in the history
  3. Update src/ansys/aedt/core/modeler/circuits/primitives_circuit.py

    Co-authored-by: gmalinve <103059376+gmalinve@users.noreply.github.com>
    DaveTwyman and gmalinve authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    7aa718d View commit details
    Browse the repository at this point in the history
  4. Update src/ansys/aedt/core/modeler/circuits/primitives_circuit.py

    Co-authored-by: gmalinve <103059376+gmalinve@users.noreply.github.com>
    DaveTwyman and gmalinve authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    bd322c4 View commit details
    Browse the repository at this point in the history
  5. Update src/ansys/aedt/core/modeler/circuits/primitives_circuit.py

    Co-authored-by: gmalinve <103059376+gmalinve@users.noreply.github.com>
    DaveTwyman and gmalinve authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    44827f3 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. -Moved create_page and get_num_pages into maxwellcircuit.py, they sho…

    …uld not be in circuit.py.
    
    -Replaced set_property method with parameter method.
    -Added example in docstring for create_i_sin and create_v_sin.
    -Added more checks for create_voltage_source and create_current_source name types in unit tests.
    -Moved create_page and get_num_pages unit tests to test_35_MaxwellCircuit.py
    -Added assert not to two of the unit tests
    DaveTwyman committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    29eeb97 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' of https://github.com/ansys/pyaedt into 5282-Add-…

    …Missing-Circuit-Elements
    DaveTwyman committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3f56946 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'main' into 5282-Add-Missing-Circuit-Elements

    # Conflicts:
    #	tests/system/general/test_21_Circuit.py
    DaveTwyman committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    e053aab View commit details
    Browse the repository at this point in the history
  4. CHORE: Auto fixes from pre-commit.com hooks

    For more information, see https://pre-commit.ci
    pre-commit-ci[bot] committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    8cefb93 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    44c9258 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8b94bd1 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Added property to get number of pages in schematic instead of a method.

    Unit test 12 no longer needed.
    Added nb_pages after each page is created in unit test 11 to catch cases where pages are not created.
    DaveTwyman committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0291fd4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9496014 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Configuration menu
    Copy the full SHA
    8a765fb View commit details
    Browse the repository at this point in the history
  2. Changed from using a method called 'get_num_pages' to a property call…

    …ed 'nb_pages'.
    
    Change made for circuit so implementation is the same as maxwellcircuit.
    DaveTwyman committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e8bfc8f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9f129ad View commit details
    Browse the repository at this point in the history