Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: RCS class #5405

Merged
merged 116 commits into from
Nov 20, 2024
Merged

FEAT: RCS class #5405

merged 116 commits into from
Nov 20, 2024

Conversation

Samuelopez-ansys
Copy link
Member

No description provided.

@SMoraisAnsys
Copy link
Collaborator

@Samuelopez-ansys I did a few changes on the PR:

  • Adding integration testing dependencies to the project AND to CICD (wasn't part of the current CICD)
  • Adding unit and integration tests on MonostaticRCSData
  • Removing unused private attributes see e50bcaa
  • Changing raised Exception types to help with testing (Exception was too wide)
  • Fixing the check on file extension ("h5" -> ".h5")
  • Fixing call to logger
  • Refactoring to use private attributes instead of properties
  • Refactoring to use Path open method
  • Refactoring imports to match testing strategy

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 91.82339% with 100 lines in your changes missing coverage. Please review.

Project coverage is 84.59%. Comparing base (780a7e0) to head (dde4878).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5405      +/-   ##
==========================================
+ Coverage   84.39%   84.59%   +0.19%     
==========================================
  Files         140      142       +2     
  Lines       58671    59885    +1214     
==========================================
+ Hits        49518    50659    +1141     
- Misses       9153     9226      +73     
---- 🚨 Try these New Features:

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) November 18, 2024 07:44
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 49cd421 into main Nov 20, 2024
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/rcs_class branch November 20, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants