Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix windows nightly build #5477

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Nov 24, 2024

Associated to #5478.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Package and maintenance related label Nov 24, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (91543ea) to head (2737a0b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5477   +/-   ##
=======================================
  Coverage   84.67%   84.67%           
=======================================
  Files         143      143           
  Lines       60082    60082           
=======================================
+ Hits        50875    50876    +1     
+ Misses       9207     9206    -1     

@SMoraisAnsys SMoraisAnsys changed the title wip: test fix windows nightly build CI: Fix windows nightly build Nov 25, 2024
@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review November 25, 2024 13:44
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 2944348 into main Nov 26, 2024
74 of 75 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the ci/test-windows-doc-build branch November 26, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants