Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mesh tutorials to the main tutorials branch #1908

Open
wants to merge 15 commits into
base: doc/new-tutorials-section
Choose a base branch
from

Conversation

luisaFelixSalles
Copy link
Collaborator

@luisaFelixSalles luisaFelixSalles commented Nov 18, 2024

Add new plot tutorials to the mesh section:

List of tutorials:

  • Create a mesh from scratch
  • Get a mesh from a result file
  • Read and get specific information from a mesh
  • Get a mesh split on different parts
  • Split a mesh

Preview on how it renders:

Mesh section main page

image

Create a mesh from scratch

_D__ANSYSdev_pydpf-core_doc_build_html_user_guide_tutorials_mesh_create_a_mesh_from_scratch html

Get a mesh from a result file

_D__ANSYSdev_pydpf-core_doc_build_html_user_guide_tutorials_mesh_get_mesh_from_result_file html

Read and get specific information from a mesh

_D__ANSYSdev_pydpf-core_doc_build_html_user_guide_tutorials_mesh_read_mesh html

Get a mesh split on different parts

_D__ANSYSdev_pydpf-core_doc_build_html_user_guide_tutorials_mesh_get_specific_part_mesh html

Split a mesh

_D__ANSYSdev_pydpf-core_doc_build_html_user_guide_tutorials_mesh_split_mesh html (1)

@luisaFelixSalles luisaFelixSalles self-assigned this Nov 18, 2024
@luisaFelixSalles luisaFelixSalles changed the base branch from master to doc/new-tutorials-section November 18, 2024 16:28
@luisaFelixSalles luisaFelixSalles mentioned this pull request Nov 18, 2024
31 tasks
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (df79026) to head (b172571).
Report is 1 commits behind head on doc/new-tutorials-section.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           doc/new-tutorials-section    #1908      +/-   ##
=============================================================
- Coverage                      88.16%   88.08%   -0.09%     
=============================================================
  Files                             83       83              
  Lines                           9961     9951      -10     
=============================================================
- Hits                            8782     8765      -17     
- Misses                          1179     1186       +7     
---- 🚨 Try these New Features:

@PProfizi
Copy link
Contributor

Could we restrict the mesh from scratch tutorial to just that? I think the add data and plot data sections should appear somewhere else. Also, this is not "adding" data to the mesh but rather creating data from scratch which we then plot on the mesh. I think this is covered in the plotting tutorials, and the data part should probably be in a tutorial on creating Fields and FieldsContainers from scratch which we can add separately.

@PProfizi
Copy link
Contributor

Get a mesh from a result file: problem with rendering for the mesh_provider operator reference in the section title.
Also we should add a section regarding the meshes_provider.

@PProfizi
Copy link
Contributor

Read and get specific information from a mesh:
rename to read mesh metadata.
I see several references not rendering properly.
Also this looks like two examples where put one after the other, could we rather merge them into one, while giving indications on specifics for different solvers?

@PProfizi
Copy link
Contributor

Get a mesh split on different parts: I think we reshape the tutorial to something very small explaining how to get a mesh split by body for each solver (Fluent+CFX or LSDYNA) with the mesh_provider/meshes_provider (explain the region_scoping input pin)

Basically here the idea would be to show how to Extract a mesh as split per body

The next tutorial on Split a mesh can then be focused on splitting on already existing MeshedRegion into a MeshesContainer, based on mesh properties. There is the split_mesh operator, but there is also the two-steps way using scoping.split_on_property_type and then mesh.from_scoping(s)

@luisaFelixSalles
Copy link
Collaborator Author

Get a mesh from a result file: problem with rendering for the mesh_provider operator reference in the section title. Also we should add a section regarding the meshes_provider.

Wouldn't this section be the Extract a mesh as split per body tutorial?

@PProfizi PProfizi added the tutorials Related to PyDPF-Core tutorials label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tutorials Related to PyDPF-Core tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants