Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding warning about *mwrite. Update *vwrite warning to include *mwrite #3296

Merged
merged 10 commits into from
Jul 29, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 18, 2024

Description

Warn about *MWRITE usage.

Issue linked

Referenced in #3289
Close #3290

Checklist

@germa89 germa89 requested a review from a team as a code owner July 18, 2024 08:55
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team July 18, 2024 08:55
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the documentation Documentation related (improving, adding, etc) label Jul 18, 2024
@germa89 germa89 self-assigned this Jul 18, 2024
@germa89 germa89 enabled auto-merge (squash) July 18, 2024 09:11
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.89%. Comparing base (d50f95c) to head (44cfd67).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3296      +/-   ##
==========================================
- Coverage   87.15%   85.89%   -1.26%     
==========================================
  Files          55       55              
  Lines        9768     9773       +5     
==========================================
- Hits         8513     8395     -118     
- Misses       1255     1378     +123     

@germa89 germa89 merged commit adbfa38 into main Jul 29, 2024
59 of 60 checks passed
@germa89 germa89 deleted the docs/adding-warning-about--mwrite branch July 29, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn user of limited usage of *MWRITE.
3 participants