Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filename with /OUTPUT command in stored commands #3304

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

Gryfenfer97
Copy link
Contributor

Description

When using non interactive mode, the generated input file had a wrong /OUTPUT filename used

This PR replace the f'{tmp_out}'

/OUTPUT,f'{tmp_out}'

with the actual value of tmp_out

/OUTPUT, C:\Users\*****\AppData\Temp\tmp_qpuedlvhqh.out

for example

@Gryfenfer97 Gryfenfer97 requested a review from a team as a code owner July 22, 2024 09:48
@Gryfenfer97 Gryfenfer97 requested review from germa89 and clatapie and removed request for a team July 22, 2024 09:48
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Jul 22, 2024
@Gryfenfer97 Gryfenfer97 changed the title fix /OUTPUT command inserted in stored commands fix: filename with /OUTPUT command in stored commands Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.13%. Comparing base (a7dc074) to head (c18f728).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3304      +/-   ##
==========================================
- Coverage   87.16%   87.13%   -0.04%     
==========================================
  Files          55       55              
  Lines        9768     9768              
==========================================
- Hits         8514     8511       -3     
- Misses       1254     1257       +3     

@Gryfenfer97 Gryfenfer97 self-assigned this Jul 26, 2024
@Gryfenfer97
Copy link
Contributor Author

@germa89 i don't know if it makes sense to keep the code coverage analysis on function overloaded by mapdl_grpc

@germa89 germa89 merged commit 96082d1 into main Jul 29, 2024
65 of 66 checks passed
@germa89 germa89 deleted the fix/stored_command_output_fstring branch July 29, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants