fix(pwa): dynamic hi route and F5
#98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitesse-nuxt3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# Conflicts: # package.json
|
I Will try to use custom plugins to avoid cache hi entries and make it working when offline and missing from cache |
userquin
commented
Aug 1, 2023
| @@ -1,13 +1,31 @@ | |||
| <script setup lang="ts"> | |||
| const router = useRouter() | |||
| const route = useRoute() | |||
| const online = useOnline() | |||
| const hiOffline = ref(false) | |||
There was a problem hiding this comment.
we can switch this to message and change it in checkHiOnline
antfu
reviewed
Aug 2, 2023
Comment on lines
+45
to
+54
| { | ||
| handler: 'NetworkFirst', | ||
| urlPattern: ({ sameOrigin, url }) => sameOrigin && url.pathname.startsWith('/hi/'), | ||
| options: { | ||
| plugins: [{ | ||
| handlerDidError: async () => Response.redirect('/hi', 302), | ||
| cacheWillUpdate: async () => null, | ||
| }], | ||
| }, | ||
| }, |
There was a problem hiding this comment.
It it possible to identify dynamic routes automatically in the Nuxt module? This is a starter template after all, hard code those path isn't really helpful
There was a problem hiding this comment.
ok, I'll try to add it to the module
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
hiroute even when offline, if the entry is cached it will work (press F5 once entered a name and before going offline): a lot of work per dynamic routeIf the
/hi/<name>route is not in thehi-id-cache, thehandlerDidErrorplugin will redirect to/.EDIT: sometimes
useOnlineis not working, maybe some hydration/client problem, there is no warning/error.This will work only when using
build + startscripts, usinggenerate + start:generatescripts will not work since node/express will return 404 for the dynamic route and will not be cached.