[CALCITE-6735] Type coercion for comparisons does not coerce ROW types #4096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
force-pushed
the
issue6735
branch
from
d6ef07a to
f2ee914
Compare
|
The CI seems finished, just not detected properly by the UI. |
mihaibudiu
force-pushed
the
issue6735
branch
from
f2ee914 to
7b521a7
Compare
|
In practical terms, what this PR does is to convert a comparison of ROW values with different types to a common type using casts. |
NobiGo
reviewed
Dec 19, 2024
core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java
Show resolved
Hide resolved
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mihaibudiu
force-pushed
the
issue6735
branch
from
7b521a7 to
63fbd93
Compare
NobiGo
approved these changes
Dec 19, 2024
|
caicancai
reviewed
Dec 19, 2024
| assert sourceType.getSqlTypeName() == SqlTypeName.ROW; | ||
| List<RelDataTypeField> targetTypes = targetType.getFieldList(); | ||
| List<RelDataTypeField> sourceTypes = sourceType.getFieldList(); | ||
| assert targetTypes.size() == sourceTypes.size(); |
There was a problem hiding this comment.
Why do we need to judge this? The sizes of targettype and sourcetype may be different?
There was a problem hiding this comment.
The validator will reject such programs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also had to implement in the RexToLixTranslator casts between ROW types.