[CALCITE-6730] Add CONVERT function(enabled in Oracle library) #4108
+329
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ILuffZhe
force-pushed
the
CALCITE-6730
branch
from
55039ce to
b85217b
Compare
|
| @@ -740,6 +741,7 @@ void populate1() { | |||
| defineMethod(CONCAT_WS_SPARK, | |||
| BuiltInMethod.MULTI_TYPE_STRING_ARRAY_CONCAT_WITH_SEPARATOR.method, | |||
| NullPolicy.ARG0); | |||
| defineMethod(ORACLE_CONVERT, BuiltInMethod.ORACLE_CONVERT.method, NullPolicy.ARG0); | |||
There was a problem hiding this comment.
What do you think about changing ORACLE_CONVERT to CONVERT_ORACLE? It looks like the current naming format is functionName + dbType, for example: CONCAT_WS_SPARK, BIT_COUNT_MYSQL.
| @@ -1681,6 +1681,29 @@ public static String translateWithCharset(String s, String transcodingName) { | |||
| } | |||
| } | |||
|
|
|||
| /** Oracle's {@code CONVERT(charValue, destCharsetName[, srcCharsetName])} function, | |||
| * return null if s is null or empty. */ | |||
| public static String oracleConvert(String s, String... args) { | |||
There was a problem hiding this comment.
Similar to the previous suggestion, if oracleConvert could be changed to convertOracle, perhaps this would be consistent with the existing regexpReplacePg.
| * | ||
| * <p>It has a slight different semantics to standard SQL's | ||
| * {@link SqlStdOperatorTable#CONVERT} function on operands' order, and default | ||
| * charset will be used if the {@code srcCharsetName} ixs not specified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.