Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Hana] Corrected changes in data source updates, several errors and problems with no pom files #15127

Closed
wants to merge 8 commits into from

Conversation

xinxingi
Copy link
Contributor

@xinxingi xinxingi commented Nov 6, 2023

deal with the problem
close #14550

Brief change log

Verify this pull request

image

@xinxingi xinxingi requested a review from caishunfeng as a code owner November 6, 2023 09:19
@SbloodyS SbloodyS added the discussion discussion label Nov 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2f28257) 38.24% compared to head (b09aae9) 38.31%.

❗ Current head b09aae9 differs from pull request most recent head 039ee62. Consider uploading reports for the commit 039ee62 to get more accurate results

Files Patch % Lines
.../plugin/datasource/hana/HanaDataSourceChannel.java 0.00% 2 Missing ⚠️
...in/datasource/hana/HanaPooledDataSourceClient.java 0.00% 2 Missing ⚠️
...datasource/hana/param/HanaDataSourceProcessor.java 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15127      +/-   ##
============================================
+ Coverage     38.24%   38.31%   +0.07%     
- Complexity     4696     4724      +28     
============================================
  Files          1285     1292       +7     
  Lines         45471    45533      +62     
  Branches       4952     4951       -1     
============================================
+ Hits          17391    17448      +57     
- Misses        26188    26191       +3     
- Partials       1892     1894       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun changed the title Corrected changes in data source updates, several errors and problems with no pom files [Bug][Hana] Corrected changes in data source updates, several errors and problems with no pom files Nov 19, 2023
@ruanwenjun ruanwenjun force-pushed the fix_hana_no_pom_20231106 branch from 4162e65 to 039ee62 Compare November 19, 2023 07:53
@ruanwenjun ruanwenjun added the bug Something isn't working label Nov 19, 2023
@ruanwenjun
Copy link
Member

Have you tested this? Can you provide ui screenshot?

@fuchanghai
Copy link
Member

Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image we also should add new dependencies in ``` LICENSE ``` which

Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 25 Code Smells

77.3% 77.3% Coverage
0.0% 0.0% Duplication

@zhongjiajie
Copy link
Member

zhongjiajie commented Jan 3, 2024

close by #15260 sorry for replying later, and thanks for your contribution @xinxingi

@zhongjiajie zhongjiajie closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working discussion discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants