Skip to content

Commit

Permalink
[Enhancement] (nereids)implement showPrivilegesCommand in nereids (#4…
Browse files Browse the repository at this point in the history
…3119)

Issue Number: close #42769
  • Loading branch information
Vallishp authored Nov 18, 2024
1 parent 846138c commit f5bffd4
Show file tree
Hide file tree
Showing 6 changed files with 111 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ supportedShowStatement
| SHOW REPOSITORIES #showRepositories
| SHOW ROLES #showRoles
| SHOW PARTITION partitionId=INTEGER_VALUE #showPartitionId
| SHOW PRIVILEGES #showPrivileges
| SHOW PROC path=STRING_LITERAL #showProc
| SHOW STORAGE? ENGINES #showStorageEngines
| SHOW CREATE MATERIALIZED VIEW mvName=identifier
Expand Down Expand Up @@ -309,7 +310,6 @@ unsupportedShowStatement
| SHOW SNAPSHOT ON repo=identifier wildWhere? #showSnapshot
| SHOW ALL? GRANTS #showGrants
| SHOW GRANTS FOR userIdentify #showGrantsForUser
| SHOW PRIVILEGES #showPrivileges
| SHOW FULL? BUILTIN? FUNCTIONS
((FROM | IN) database=multipartIdentifier)? wildWhere? #showFunctions
| SHOW GLOBAL FULL? FUNCTIONS wildWhere? #showGlobalFunctions
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@
import org.apache.doris.nereids.DorisParser.ShowLastInsertContext;
import org.apache.doris.nereids.DorisParser.ShowPartitionIdContext;
import org.apache.doris.nereids.DorisParser.ShowPluginsContext;
import org.apache.doris.nereids.DorisParser.ShowPrivilegesContext;
import org.apache.doris.nereids.DorisParser.ShowProcContext;
import org.apache.doris.nereids.DorisParser.ShowProcedureStatusContext;
import org.apache.doris.nereids.DorisParser.ShowRepositoriesContext;
Expand Down Expand Up @@ -451,6 +452,7 @@
import org.apache.doris.nereids.trees.plans.commands.ShowLastInsertCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowPartitionIdCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowPluginsCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowPrivilegesCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowProcCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowProcedureStatusCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowRepositoriesCommand;
Expand Down Expand Up @@ -4170,4 +4172,9 @@ public LogicalPlan visitShowTableId(ShowTableIdContext ctx) {
}
return new ShowTableIdCommand(tableId);
}

@Override
public LogicalPlan visitShowPrivileges(ShowPrivilegesContext ctx) {
return new ShowPrivilegesCommand();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ public enum PlanType {
SHOW_PARTITIONID_COMMAND,
SHOW_PROC_COMMAND,
SHOW_PLUGINS_COMMAND,
SHOW_PRIVILEGES_COMMAND,
SHOW_REPOSITORIES_COMMAND,
SHOW_ROLE_COMMAND,
SHOW_STORAGE_ENGINES_COMMAND,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

package org.apache.doris.nereids.trees.plans.commands;

import org.apache.doris.catalog.Column;
import org.apache.doris.catalog.ScalarType;
import org.apache.doris.mysql.privilege.Privilege;
import org.apache.doris.nereids.trees.plans.PlanType;
import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
import org.apache.doris.qe.ConnectContext;
import org.apache.doris.qe.ShowResultSet;
import org.apache.doris.qe.ShowResultSetMetaData;
import org.apache.doris.qe.StmtExecutor;

import com.google.common.collect.Lists;

import java.util.List;

/**
* show privileges command
*/
public class ShowPrivilegesCommand extends ShowCommand {
private static final ShowResultSetMetaData META_DATA;

static {
ShowResultSetMetaData.Builder builder = ShowResultSetMetaData.builder();

builder.addColumn(new Column("Privilege", ScalarType.createVarchar(100)));
builder.addColumn(new Column("Context", ScalarType.createVarchar(100)));
builder.addColumn(new Column("Comment", ScalarType.createVarchar(100)));

META_DATA = builder.build();
}

/**
* constructor
*/

public ShowPrivilegesCommand() {
super(PlanType.SHOW_PRIVILEGES_COMMAND);
}

@Override
public ShowResultSet doRun(ConnectContext ctx, StmtExecutor executor) throws Exception {
List<List<String>> infos = Lists.newArrayList();
Privilege[] values = Privilege.values();
for (Privilege privilege : values) {
if (!privilege.isDeprecated()) {
infos.add(Lists.newArrayList(privilege.getName(), privilege.getContext(), privilege.getDesc()));
}
}
return new ShowResultSet(META_DATA, infos);
}

@Override
public <R, C> R accept(PlanVisitor<R, C> visitor, C context) {
return visitor.visitShowPrivilegesCommand(this, context);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
import org.apache.doris.nereids.trees.plans.commands.ShowLastInsertCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowPartitionIdCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowPluginsCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowPrivilegesCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowProcCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowProcedureStatusCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowRepositoriesCommand;
Expand Down Expand Up @@ -318,4 +319,8 @@ default R visitDropRoleCommand(DropRoleCommand dropRoleCommand, C context) {
default R visitShowTableIdCommand(ShowTableIdCommand showTableIdCommand, C context) {
return visitCommand(showTableIdCommand, context);
}

default R visitShowPrivilegesCommand(ShowPrivilegesCommand showPrivilegesCommand, C context) {
return visitCommand(showPrivilegesCommand, context);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

import org.junit.Assert;

suite("test_nereids_show_privileges") {
// only check syntax
checkNereidsExecute("""show privileges""")
}

0 comments on commit f5bffd4

Please sign in to comment.