-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #3887] The method of verifying no exception thrown is not appropriate #3889
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3889 +/- ##
============================================
- Coverage 14.24% 13.93% -0.31%
+ Complexity 1320 1292 -28
============================================
Files 579 570 -9
Lines 28967 28848 -119
Branches 2802 2811 +9
============================================
- Hits 4125 4020 -105
- Misses 24450 24455 +5
+ Partials 392 373 -19
... and 143 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3889 +/- ##
============================================
- Coverage 14.24% 13.93% -0.31%
+ Complexity 1320 1292 -28
============================================
Files 579 570 -9
Lines 28967 28848 -119
Branches 2802 2811 +9
============================================
- Hits 4125 4020 -105
- Misses 24450 24455 +5
+ Partials 392 373 -19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please resolve conflicts.
|
||
boolean isSameWeightGroup() { | ||
return sameWeightGroup; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using a @Getter
lombok annotation?
Well, this method doesn't take up a lot of space and can be left unchanged in this PR if you don't feel it's necessary.
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback. If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh. |
Fixes #3887.
Motivation
See "Enhancement Request" in issue.
Modifications
See "Describe the solution you'd like" in issue.
Documentation