[FLINK-34165] Update apache download url #170
Conversation
There was a problem hiding this comment.
@JingGe I checked the download sites at the ASF:
dlcdn.apache.org is our CDN for downloads.a.o, which should arguably be faster than just going straight to downloads.a.o. While the CDN is global, we've had issues in certain countries where it's either slow or unavailable, hence the direct link. Using either is totally fine.
I think we can point all links to https://dlcdn.apache.org. I've verified that this works for existing/active supported versions (currently 1.18, 1.17 and 1.16) but also for older versions (1.15), because that will redirect straight to the archive.
Examples:
This all works, supported versions
https://dlcdn.apache.org/flink/flink-1.18.1/flink-1.18.1-bin-scala_2.12.tgz
https://dlcdn.apache.org/flink/flink-1.18.1/flink-1.18.1-bin-scala_2.12.tgz.asc
https://dlcdn.apache.org/flink/flink-1.18.1/flink-1.18.1-bin-scala_2.12.tgz.sha512
This doesn't work for CDN, since it's not a supported version anymore
https://dlcdn.apache.org/flink/flink-1.15.0/flink-1.15.0-bin-scala_2.12.tgz
https://dlcdn.apache.org/flink/flink-1.15.0/flink-1.15.0-bin-scala_2.12.tgz.asc
https://dlcdn.apache.org/flink/flink-1.15.0/flink-1.15.0-bin-scala_2.12.tgz.sha512
This works doesn't work for all supported/non-supported releases (binary for non-supported version is broken)
https://downloads.apache.org/flink/flink-1.18.1/flink-1.18.1-bin-scala_2.12.tgz
https://downloads.apache.org/flink/flink-1.18.1/flink-1.18.1-bin-scala_2.12.tgz.asc
https://downloads.apache.org/flink/flink-1.18.1/flink-1.18.1-bin-scala_2.12.tgz.sha512
https://downloads.apache.org/flink/flink-1.15.0/flink-1.15.0-bin-scala_2.12.tgz
https://downloads.apache.org/flink/flink-1.15.0/flink-1.15.0-bin-scala_2.12.tgz.asc
https://downloads.apache.org/flink/flink-1.15.0/flink-1.15.0-bin-scala_2.12.tgz.sha512
Edit: wait, it doesn't work for https://downloads.apache.org/flink/flink-1.15.0/flink-1.15.0-bin-scala_2.12.tgz
So, then I think we could change all of the links to dlcdn.apache.org :)
|
@MartijnVisser yes, https://dlcdn.apache.org/ is another option which works too. I will update to use that one. Thanks! Jus out of curiosity, do you know why dlcdn wasn't used for asc in the first place? |
|
BTW, there are two urls defined for tgz and asc. This PR only changes asc url. For asc, we could use cdn but the difference should be very limited. WDYT? |
I think we should keep them the same for consistency |
Make sense. I am thinking why it was not consistent in the first place. (cdn was not used for asc previously) |
|
There is a comment for it:
Line 128 in df317cb I think we should indeed use the direct download url. @MartijnVisser WDYT? |
JingGe
force-pushed
the
FLINK-34165-update-apache-dl-link
branch
from
f213fbd to
1b90d8b
Compare
|
Thanks @MartijnVisser for the review! |
Current URL throws a 404 and 1.18.0 is not hosted anywhere. Also switching the download URL as per apache/flink-docker#170
Current URL throws a 404 and 1.18.0 is not hosted anywhere. Also switching the download URL as per apache/flink-docker#170 ci: Update flink link to archive.apache.org
Current URL throws a 404 and 1.18.0 is not hosted anywhere. Also switching the download URL as per apache/flink-docker#170 ci: Update flink link to archive.apache.org
Current URL throws a 404 and 1.18.0 is not hosted anywhere. Also switching the download URL as per apache/flink-docker#170 ci: Update flink link to archive.apache.org (cherry picked from commit a452101)
Apache changed its download link.