-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#146 - Update dependencies #147
Conversation
reckart
commented
Oct 1, 2023
- Updated basically all dependencies in the package.json file
- Set minimum required node version to 16 since that is what some of the updated dependencies require
19574bc
to
3d6724e
Compare
- Updated basically all dependencies in the package.json file - Set minimum required node version to 16 since that is what some of the updated dependencies require
3d6724e
to
02b1cb4
Compare
@tilgovi @BigBlueHat @Treora I have done pretty radical update of dependencies here. Looks like the build process is happy. Anybody care to have a look at these changes since I'm not really too familiar with the tooling used by Apache Annotator. I still think switching to plain npm would be better these days (and drop lerna and yarn). Also I thing esbuild instead of webpack would be nice :) ... but that would be a different issue/PR. |
Looks great. I will make a PR to drop Yarn for NPM, because I don't think there is any benefit to continuing to use Yarn (especially not without the advanced features). Can you say anything about the non-dependency changes here? The ajv invocation and the lerna.json? |
I'm guessing useWorkspaces is just gone these days. I started looking at updating Lerna and trying out Nx a while back. I'll see where my branch got and try to see whether it's worth doing anything with these tools still. Thanks again for looking at this. |
Lerna said that And |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!