Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#146 - Update dependencies #147

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented Oct 1, 2023

  • Updated basically all dependencies in the package.json file
  • Set minimum required node version to 16 since that is what some of the updated dependencies require

@reckart reckart added dependencies Pull requests that update a dependency file ⚙️ Refactoring Improvement for development or maintainability labels Oct 1, 2023
@reckart reckart added this to the 0.3.0 milestone Oct 1, 2023
@reckart reckart self-assigned this Oct 1, 2023
@reckart reckart force-pushed the refactoring/146-Update-dependencies branch 3 times, most recently from 19574bc to 3d6724e Compare October 1, 2023 19:02
- Updated basically all dependencies in the package.json file
- Set minimum required node version to 16 since that is what some of the updated dependencies require
@reckart reckart force-pushed the refactoring/146-Update-dependencies branch from 3d6724e to 02b1cb4 Compare October 1, 2023 19:09
@reckart
Copy link
Member Author

reckart commented Oct 1, 2023

@tilgovi @BigBlueHat @Treora I have done pretty radical update of dependencies here. Looks like the build process is happy. Anybody care to have a look at these changes since I'm not really too familiar with the tooling used by Apache Annotator.

I still think switching to plain npm would be better these days (and drop lerna and yarn). Also I thing esbuild instead of webpack would be nice :) ... but that would be a different issue/PR.

@reckart reckart requested review from tilgovi and Treora October 1, 2023 19:12
@tilgovi
Copy link
Contributor

tilgovi commented Oct 1, 2023

Looks great. I will make a PR to drop Yarn for NPM, because I don't think there is any benefit to continuing to use Yarn (especially not without the advanced features).

Can you say anything about the non-dependency changes here? The ajv invocation and the lerna.json?

@tilgovi
Copy link
Contributor

tilgovi commented Oct 1, 2023

I'm guessing useWorkspaces is just gone these days.

I started looking at updating Lerna and trying out Nx a while back. I'll see where my branch got and try to see whether it's worth doing anything with these tools still.

Thanks again for looking at this.

@reckart
Copy link
Member Author

reckart commented Oct 2, 2023

Lerna said that useWorkspaces no longer exists.

And auto was no longer a valid value for schemaId in Ajv. I considered specifying a particular schema version, but since the parameter is optional and the build works without specifying a version, I left it without the schemaId.

Copy link
Contributor

@tilgovi tilgovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@reckart reckart merged commit 40c0a5c into main Oct 3, 2023
1 check passed
@reckart reckart deleted the refactoring/146-Update-dependencies branch October 3, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ⚙️ Refactoring Improvement for development or maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants