[INLONG-11520][SDK] Remove DirtyServerType, use SinkType #11521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloyszhang
previously approved these changes
Nov 21, 2024
fuweng11
previously approved these changes
Nov 21, 2024
luchunliang
previously approved these changes
Nov 22, 2024
vernedeng
force-pushed
the
INLONG-11520
branch
from
6902506
to
26f3b75
Compare
vernedeng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11520
Motivation
Add more enum of DirtyServerType
Modifications
Add
ICEBERG("Iceberg"), HIVE("Hive"), STAR_ROCKS("StarRocks"), KAFKA("Kafka"), PULSAR("Pulsar"), ELASTICSEARCH("Elasticsearch"), MYSQL("Mysql")Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation