-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: enable consumer auth tests #17885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for one small typo
@MethodSource(Array("getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_17696")) | ||
def testOffsetFetchWithNoTopicAccess(quorum: String, groupProtocol: String): Unit = { | ||
@MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll")) | ||
def getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_17696(quorum: String, groupProtocol: String): Unit = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes, my bad, fixed.
No changes in logic, just enabling some consumer auth tests that were marked as blocked on an open consumer bug, but they are not really affected by it. All tests pass on trunk.