Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: enable consumer auth tests #17885

Merged
merged 4 commits into from
Nov 22, 2024
Merged

MINOR: enable consumer auth tests #17885

merged 4 commits into from
Nov 22, 2024

Conversation

lianetm
Copy link
Contributor

@lianetm lianetm commented Nov 20, 2024

No changes in logic, just enabling some consumer auth tests that were marked as blocked on an open consumer bug, but they are not really affected by it. All tests pass on trunk.

@github-actions github-actions bot added core Kafka Broker tests Test fixes (including flaky tests) small Small PRs labels Nov 20, 2024
@lianetm lianetm marked this pull request as ready for review November 20, 2024 20:36
@lianetm
Copy link
Contributor Author

lianetm commented Nov 20, 2024

Hey @chia7712, would you have time for a quick look at this minor follow-up for #17670? These tests were tagged as blocked on KAFKA_17696 but they aren't really, they just pass on trunk (the ones that are truly blocked on KAFKA_17696 will be enabled as part of it). Thanks!

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one small typo

@MethodSource(Array("getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_17696"))
def testOffsetFetchWithNoTopicAccess(quorum: String, groupProtocol: String): Unit = {
@MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
def getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_17696(quorum: String, groupProtocol: String): Unit = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, my bad, fixed.

@lianetm lianetm merged commit e60e61c into apache:trunk Nov 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Kafka Broker small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants