KAFKA-18059: kafka-metadata-quorum.sh add-controller subcommand can't recognize argument --config #17907
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In KIP-853, it uses following command as adding controller example.
The script returns "kafka-metadata-quorum: error: unrecognized arguments: '--config'". The correct way to add controller is like following:
From @chia7712's suggestion, we keep using
--command-config
to avoid breaking change. However, inMetadataQuorumCommand
, the--command-config
description is "Property file containing configs to be passed to Admin Client.". We should update the description to mention it's also used as controller property file foradd-controller
command.Committer Checklist (excluded from commit message)