Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-18059: kafka-metadata-quorum.sh add-controller subcommand can't recognize argument --config #17907

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

FrankYang0529
Copy link
Member

In KIP-853, it uses following command as adding controller example.

kafka-metadata-quorum --bootstrap-server <endpoints> add-controller --config controller.properties

The script returns "kafka-metadata-quorum: error: unrecognized arguments: '--config'". The correct way to add controller is like following:

kafka-metadata-quorum --bootstrap-server <endpoints> --command-config controller.properties add-controller

From @chia7712's suggestion, we keep using --command-config to avoid breaking change. However, in MetadataQuorumCommand, the --command-config description is "Property file containing configs to be passed to Admin Client.". We should update the description to mention it's also used as controller property file for add-controller command.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added tools small Small PRs labels Nov 22, 2024
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit eb641b5 into apache:trunk Nov 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants