Try to validate commit headers. #6630
Open
+117
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
CI
mbien
force-pushed
the
ci-email-checker
branch
2 times, most recently
from
0770006
to
127107a
Compare
mbien
force-pushed
the
ci-email-checker
branch
4 times, most recently
from
d17b7ab
to
a3f84da
Compare
|
well late :D will need rebase. |
mbien
force-pushed
the
ci-email-checker
branch
from
a3f84da
to
5651995
Compare
|
rebased, removed string templates and fixed a bug |
mbien
commented
Sep 26, 2024
| java: [ '17' ] | ||
| java: [ '23' ] |
There was a problem hiding this comment.
I hope this doesn't cause issues, but we will see next time this PR fully builds and all paperwork checks run, I removed the no-build label now.
There was a problem hiding this comment.
this seems to work. But I might change it back anyway. Probably not worth the risk to run sig test-tests on JDK 23.
|
LGTM |
ebarboni
approved these changes
Sep 27, 2024
- simple script to check if all commits have proper email addresses - looks for empty or single word subject messages - warns about missing blank line after subject - logs errors/warnings to the github actions summary page
mbien
force-pushed
the
ci-email-checker
branch
from
5651995
to
1e4d17b
Compare
|
removed the test commits and updated the error messages a bit |
mbien
commented
Sep 30, 2024
Comment on lines
+108
to
+114
| boolean checkBlankLineAfterSubject(String blank, int i) { | ||
| if (!blank.isBlank()) { | ||
| println("::warning::blank line after subject recommended in commit " + i + " (subject over 50 char limit?)"); | ||
| // return false; | ||
| } | ||
| return true; | ||
| } |
There was a problem hiding this comment.
i am not sure about this. Will anyone even look at the warnings? Should I turn this off for now?
I suppose a better place for checks like this would be the NB commit window ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back when I setup the paperwork job, I didn't know that gh can generate patch files yet. The problem was to figure out what commits are actually new in the PR. I gave it a few attempts but got distracted with more important things.
this adds:
output in workflow summary:
output in job log: