-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Markdown javadoc (JEP-467) #7491
Conversation
java/java.sourceui/src/org/netbeans/api/java/source/ui/ElementJavadoc.java
Outdated
Show resolved
Hide resolved
...tor.base/test/unit/src/org/netbeans/modules/java/editor/base/javadoc/JavadocImportsTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Thanks.
Unless there are objections, I will merge in the next day or so. |
probably ok to merge as new feature, but I fear that this might confuse some of the javadoc editor hints since they probably don't expect markdown. |
It might confuse something. Or some piece of code may be confused by the current situation (where the model already includes AST model of Markdown javadoc, but the JavadocUtilities don't understand it). I don't think this is an actionable claim, and I think this change is a step in finding out what's wrong, if anything, and fix it. |
it was just a feeling, but here an example after testing it quickly: ///
/// @param str
///
public static void foo(String str, int i) {} the hint will suggest to insert the doc for result: ///
/// @param str
///
/**
*
* @param str
* @param i
*/
public static void foo(String str, int i) {}
of course. That is why I said I think it is ok to merge this as new feature. |
Hm, yes that happens. But it happens without this patch as well, so this is not something caused by this patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to approve - looks good!
A patch to support Markdown javadoc (JEP-467).