Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open up and make accessible Resolver Public APIs #7777

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Sep 20, 2024

As documented here:
https://maven.apache.org/resolver/api-compatibility.html

Doing this is not only "right", but makes possible migration off the legacy classes, like shared.graph, shared.tree and many others are.

After migration, the list of friend classes should be narrowed down by dropping unused stuff.

As documented here:
https://maven.apache.org/resolver/api-compatibility.html

Doing this is not only "right", but makes possible migration
off the legacy classes, like shared.graph, shared.tree and
many others are.

After migration, the list of friend classes should be narrowed
down by dropping unused stuff.
@cstamas
Copy link
Member Author

cstamas commented Sep 20, 2024

Deprecated stuff like api.transform or spi.servicelocator and others intentionally left out, they are not needed (and are deprecated anyway).

@mbien mbien added the Maven [ci] enable "build tools" tests label Sep 20, 2024
@mbien
Copy link
Member

mbien commented Sep 20, 2024

ag -l -E java DependencyTreeFactory
java/maven/src/org/netbeans/modules/maven/queries/MavenDependenciesImplementation.java
java/maven/src/org/netbeans/modules/maven/nodes/DependencyNode.java
java/maven/src/org/netbeans/modules/maven/dependencies/ExcludeDependencyPanel.java
java/maven.embedder/src/org/netbeans/modules/maven/embedder/DependencyTreeFactory.java
java/maven.repository/src/org/netbeans/modules/maven/repository/ui/ArtifactMultiViewFactory.java

the dated dep isn't used a lot luckily. we might be able to migrate this in one go - or at least some of it.

@cstamas
Copy link
Member Author

cstamas commented Sep 20, 2024

Yes, but things like ArtifactRepository (also deprecated in 3.9.x) have way bigger proliferation, and stands in way to support things like "split repository"... so there is quite some things to clean up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maven [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants