lsp.client: mark occurrences sidebar and make occurrences highlighting configurable #7807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasblaesing
added
LSP
lahodaj
approved these changes
Oct 18, 2024
matthiasblaesing
force-pushed
the
lsp_mark_provider
branch
from
e44ca06
to
1d5453f
Compare
|
@lahodaj thanks for review. I rebased the change onto master and resolved the merge conflict. Will merge once green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration:
Result:
Important observations:
heroesmembers are not only highlighted in the code, but also on the right sidebarheroesanymore, yet the highlight is retained, as no other highlighting is active (this is the result of the "Keep Marks" setting)