PHP: Added support for Psalm static analyzer #7810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pincher2012
reviewed
Sep 29, 2024
php/php.code.analysis/src/org/netbeans/modules/php/analysis/ImportantFilesImpl.java
Outdated
Show resolved
Hide resolved
troizet
force-pushed
the
php_psalm_support
branch
from
4621fee
to
06f6512
Compare
tmysik
reviewed
Sep 30, 2024
php/php.code.analysis/src/org/netbeans/modules/php/analysis/parsers/CheckStyleReportParser.java
Show resolved
Hide resolved
tmysik
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Looks good to me; please, let @junichi11 review it too. Thanks!
junichi11
reviewed
Oct 3, 2024
php/php.code.analysis/src/org/netbeans/modules/php/analysis/commands/Psalm.java
Outdated
Show resolved
Hide resolved
php/php.code.analysis/src/org/netbeans/modules/php/analysis/parsers/CheckStyleReportParser.java
Outdated
Show resolved
Hide resolved
troizet
force-pushed
the
php_psalm_support
branch
from
06f6512
to
e311896
Compare
Added a test for parsing psalm output. |
tmysik
approved these changes
Oct 5, 2024
junichi11
reviewed
Oct 5, 2024
php/php.code.analysis/test/unit/data/psalm/PsalmSupport/test/src/CalculatorTest.php
Outdated
Show resolved
Hide resolved
troizet
force-pushed
the
php_psalm_support
branch
from
e311896
to
f05a02e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
Psalmstatic analyzer.https://psalm.dev/
php_psal_support.mp4
Most of it is copying code from
PHPStan. The main differences are in the command to start the analyzer in Psalm.java.Also in this PR the file
PHPStanStyleReportParser.javais renamed toCheckStyleReportParser.javaand is used for bothPHPStanandPsalm.Also, the image file for
Psalmis a copy oftextDetail.pngfrom theSearch APImodule.Tested on
Psalmversion 5.26.1