riscv: add a return value to riscv_swint #13564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Arch: risc-v
|
[Experimental Bot, please feedback here] Yes, the PR appears to meet the NuttX requirements. Here's a breakdown:
Recommendations for Improvement:
Overall: The PR provides a good starting point. Adding the recommended details will ensure a smoother review process and increase the likelihood of a quick merge. |
lupyuen
requested changes
Sep 21, 2024
There was a problem hiding this comment.
OSTest seems to hang at vfork() for rv-virt:knsh? https://gist.github.com/lupyuen/8daee1123a52e222fb601287a00af149
$ git clone https://github.com/hujun260/nuttx --branch apache_10 nuttx
$ tools/configure.sh rv-virt:knsh
...
$ qemu-system-riscv32 -semihosting -M virt,aclint=on -cpu rv32 -kernel nuttx -bios opensbi-1.5-rv-bin/share/opensbi/ilp32/generic/firmware/fw_dynamic.bin -nographic
QEMU emulator version 9.0.2
OpenSBI v1.5
...
nsh> ostest
user_main: vfork() test
[Hangs here]
Update: rv-virt:knsh64 also hangs at vfork(): https://gist.github.com/lupyuen/ce2e2cb328073d25743adbd4bc4a9b87
… switch is required This commit fixes the regression from apache#13561 Signed-off-by: hujun5 <hujun5@xiaomi.com>
i fixed this issue |
lupyuen
approved these changes
Sep 21, 2024
There was a problem hiding this comment.
OSTest is now OK on rv-virt:knsh, rv-virt:knsh64 and milkv_duos:nsh thanks!
acassis
approved these changes
Sep 22, 2024
|
Sorry @hujun260 I think we might have a Race Condition that's intermittently hanging and failing the Signals Test in OSTest. Yesterday Milk-V Duo S SBC (SG2000) tested OK. But today it's hanging: knsh64 fails the Signal Test with a Segmentation Fault (it was OK yesterday): Are you able to reproduce this problem when you re-run knsh64 a few times? Thanks! |
|
Hi @hujun260, this PR did not fix the issue introduced by #13561 for |
ok i,ll look into this issue |
#13585 |
can you reproduce this issue using qemu? |
It doesn't make sense to try to reproduce this problem on QEMU: it's a different chip. ESP32-C3 has its own IRQs and memory protection unit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add a return value to riscv_swint indicating whether a context switch is required
This commit fixes the regression from #13561
Impact
Testing
ostest