-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master #13615
Master #13615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usbconsole weact STM32H743VI fix
[Experimental Bot, please feedback here] Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. No, this PR does not fully meet the NuttX requirements. Here's why:
To improve this PR:
|
Hi @buzdalin thank you for your contribution. Please fix my comments. You can read the documentation explaining how to fix and push the modifications to this PR: |
Hi @TOMASHEVSKIYIVAN, thanks for fixing the comments. Please don't use Merge, use git rebase, as explained in the documentation. Also squash the PRs as explained in the link I sent to you early |
The CI is failing because this small issue:
|
@acassis, please excuse me. I'm kinda newbie in git and github |
71bebeb
to
6b8f57e
Compare
@acassis guess i created new pr... |
Seems better, but you forgot to fix: Error: /home/runner/work/nuttx/nuttx/nuttx/boards/arm/stm32h7/weact-stm32h743/include/board.h:346:0: error: Wrong column position or missing blank line before comment You can test it before push the commit, this way: ./tools/checkpatch.sh -g HEAD~...HEAD |
Don't worry! You are learning by doing! |
@TOMASHEVSKIYIVAN now it is passing in the CI, but you forgot to squash the PR :-) |
c429f3a
to
2f0c481
Compare
fix previous problemc added defconfig for weact-stm32h743:nshusb board.h Wrong column position or missing blank line before comment: FIX hopefully last commit
2f0c481
to
760d1a9
Compare
Summary
fixed usbconsole on weact STM32H743VI
Impact
new debug experience for users
Testing