Skip to content
This repository has been archived by the owner on May 9, 2020. It is now read-only.

[OFBIZ-10934] Replace replaceAll() with replace() when not usng regex #31

Open
wants to merge 10,000 commits into
base: trunk
Choose a base branch
from
Open

[OFBIZ-10934] Replace replaceAll() with replace() when not usng regex #31

wants to merge 10,000 commits into from

Conversation

bd2019us
Copy link

Fix ISSUE #OFBIZ-10934. Change replaceAll() to replace() when a regex is not used for better performance

dixitdeepak and others added 30 commits November 2, 2016 20:07
@dixitdeepak
Improved: Added unit test case for following accounting related services
0928fb1 
- cancelAgreement
- copyAgreement
- getCommissionForProduct
-  createBudget
-  updateBudgetStatus
-  updateProductAverageCostOnReceiveInventory
-  getProductAverageCost
 (OFBIZ-8719)(OFBIZ-8720)(OFBIZ-8721)(OFBIZ-8749)(OFBIZ-8750)(OFBIZ-8751)(OFBIZ-8752)

Thanks  Deepak Nigam  for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767773 13f79535-47bb-0310-9956-ffa450edef68
@dixitdeepak
Improved: Added unit test case for following party related services
7bed604 
- copyPartyContactMechs
- createCommunicationEvent
- createCommunicationEventRole
- createCommunicationEventRoleWithoutPermission
- createCommunicationEventWithoutPermission
- createContactMech
- createEmailAddress
- createPartyContactMech
- createPartyContactMechPurpose
- createPartyDataSource
- createPartyEmailAddress
- createPartyIdentifications

 (OFBIZ-8536)(OFBIZ-8509)(OFBIZ-8510)(OFBIZ-8511)(OFBIZ-8512)(OFBIZ-8513)(OFBIZ-8514)(OFBIZ-8515)(OFBIZ-8516)(OFBIZ-8517)(OFBIZ-8518)(OFBIZ-8519)(OFBIZ-8520)
Thanks Akash Jain and Pawan Verma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767776 13f79535-47bb-0310-9956-ffa450edef68
@dixitdeepak
Improved: Added missing file in last commit.
dee770d 
 (OFBIZ-8536)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767777 13f79535-47bb-0310-9956-ffa450edef68
@dixitdeepak
Improved: Added unit test case for following party related services
6bbff55 
- createPartyNote
- createPartyRelationship
- createPartyRelationshipAndRole
- createPartyRelationshipContactAccount
- createPartyRelationshipType
- createPartyTelecomNumber
- createPersonAndUserLogin
- createPostalAddress
- createRoleType
- createTelecomNumber
- createUpdatePartyRelationshipAndRoles
- deleteCommunicationEvent
- deleteCommunicationEventWorkEffort
Removed testCreatePartyContactMechPurpose test case as it was failing, will fix it in next commit. 

 (OFBIZ-8521)(OFBIZ-8523)(OFBIZ-8524)(OFBIZ-8525)(OFBIZ-8526)(OFBIZ-8527)(OFBIZ-8528)(OFBIZ-8529)(OFBIZ-8531)(OFBIZ-8541)(OFBIZ-8542)(OFBIZ-8543)(OFBIZ-8544)
Thanks Akash Jain and Pawan Verma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767785 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
Improved: Convert WorkEffortContent entity CRUD service to entity-auto
4ff8b02 
(OFBIZ-8666)

Adds a DELETE permission to deleteWorkEffortContent service implementation to be
consistent with create and update.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767792 13f79535-47bb-0310-9956-ffa450edef68
@pythys
Reverted: partially reverted r1765127 to fix classpath issue
12aabf6 
(OFBIZ-8337)

The above mentioned revision introduced a regression in which starting
OFBiz in debug mode triggers classpath exceptions due to not finding
certain jars. Upon investigation we realized that the new logic
instantiates the loader class before the custom ClassLoader is
instantiated. The fix would take a bit more time, hence reverting now
to quickly resolve the issue and make the code base ready for the next
release. The revert essentially re-introduce a List<StartupLoader> data
set instead of a single StartupLoader.

This is a minimal revert (less than 400 lines) instead of a full revert
going above 2000 lines because we isolated only the parts that trigger the
regression mentioned above. However, we should ideally revisit this code
and clean it up again with careful attention to the class loading sequence.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767866 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
Improved: Remove redundant backend themes
3447c20 
(OFBIZ-8293)

We already already discussed several times on dev ML about reducing the number 
of OOTB backend themes and we globally agreed about doing so.

These themes are still working so we will move them to Attic from where 
(using svn history) they can be fetch to create expected plugins 
(tough I'm not sure we can yet create theme-plugins but this is expected)

After the last discussion in dev ML this is a 1st step where I remove
# bizzness time, still not complete after several years see OFBIZ-2398
# Dropping Crumbs, it's subsumed by Tomahawk which is the last variant of this 
group and more complete

I'll then test all is OK (data are used so I need to clean my local DB)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767881 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
Improved: Remove redundant backend themes
3730b87 
(OFBIZ-8293)

This completes the previous commit where bizzness time and Dropping Crumbs were
removed

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767893 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
Improved: Remove redundant backend themes
c1f599a 
(OFBIZ-8293)

This completes the previous commits where bizzness time and Dropping Crumbs were
removed

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767920 13f79535-47bb-0310-9956-ffa450edef68
@dixitdeepak
Improved: Added unit test case for following party related services
af8e2db 
- deletePartyContactMechPurpose
- deletePartyContactMechPurposeIfExists
- deletePartyRelationship
- deletePartyRole
- findPartiesById
- findPartyFromEmailAddress
- findPartyFromTelephone
- findPartyFromTelephoneComplete
- removeCommunicationEventRole
- setCommEventComplete
- setCommunicationEventRoleStatus
- setCommEventRoleToRead
- setCommunicationEventStatus
- updateCommunicationEvent
- updateCommunicationEventRole
 
(OFBIZ-8545)(OFBIZ-8546)(OFBIZ-8548)(OFBIZ-8549)(OFBIZ-8550)(OFBIZ-8551)(OFBIZ-8552)(OFBIZ-8553)(OFBIZ-8554)(OFBIZ-8555)(OFBIZ-8556)(OFBIZ-8557)(OFBIZ-8558)(OFBIZ-8559)(OFBIZ-8560)

Thanks Akash Jain and Pawan Verma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767950 13f79535-47bb-0310-9956-ffa450edef68
Implemented: Added CRUD services for PartyClassificationType, PartyCo…
d5ce135 
…ntentType, PartyGeoPoint, PartyIcsAvsOverride, PartyIdentificationType, PartyQualType, PartyType, PartyTypeAttr, PaymentAttribute, PaymentBudgetAllocation, PaymentContentType, PaymentGroupType, PaymentMethodType, PaymentType, PaymentTypeAttr, PerfRatingType, PerfReviewItemType, PeriodType, PriorityType and ProdCatalogCategoryType entities.

(OFBIZ-8606)(OFBIZ-8607)(OFBIZ-8608)(OFBIZ-8609)(OFBIZ-8610)(OFBIZ-8611)(OFBIZ-8612)(OFBIZ-8613)(OFBIZ-8614)(OFBIZ-8615)(OFBIZ-8616)(OFBIZ-8647)(OFBIZ-8648)(OFBIZ-8649)(OFBIZ-8650)(OFBIZ-8651)(OFBIZ-8724)
(OFBIZ-8725)(OFBIZ-8726)(OFBIZ-8727)

Thanks: Amit Gadaley and Rishi Solanki for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767953 13f79535-47bb-0310-9956-ffa450edef68
@dixitdeepak
Improved: Added unit test case for following party related services
c1f0674 
- updateContactMech
- updateEmailAddress
- updatePartyEmailAddress
- updatePartyGroup
- updatePartyPostalAddress
- updatePartyRelationship
- updatePartyTelecomNumber
- updatePerson
- updatePostalAddress
- updateTelecomNumber

(OFBIZ-8561)(OFBIZ-8562)(OFBIZ-8563)(OFBIZ-8564)(OFBIZ-8565)(OFBIZ-8566)(OFBIZ-8567)(OFBIZ-8568)(OFBIZ-8569)(OFBIZ-8570)

Thanks Akash Jain and Pawan Verma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767955 13f79535-47bb-0310-9956-ffa450edef68
Implemented: Added CRUD services for ProdConfItemContentType, Product…
c009d41 
…AssocType, UserPrefGroupType, WebPreferenceType, WorkEffortAssocAttribute, WorkEffortAssocType, WorkEffortAssocTypeAttr, WorkEffortBilling, WorkEffortContentType, WorkEffortGoodStandardType, WorkEffortPurposeType, WorkEffortType, WorkEffortTypeAttr, WorkReqFulfType, UomType, UomGroup, ProductPricePurpose, ProductPriceType, ProductStoreGroupRole and ProductStoreGroupRollup entities.

(OFBIZ-8729)(OFBIZ-8730)(OFBIZ-8792)(OFBIZ-8793)(OFBIZ-8794)(OFBIZ-8795)(OFBIZ-8796)(OFBIZ-8797)(OFBIZ-8798)(OFBIZ-8799)(OFBIZ-8800)(OFBIZ-8801)(OFBIZ-8802)(OFBIZ-8803)(OFBIZ-8788)(OFBIZ-8789)(OFBIZ-8767)
(OFBIZ-8768)(OFBIZ-8769)(OFBIZ-8770)

Thanks: Chinmay Patidar, Amit Gadaley and Rishi Solanki for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767965 13f79535-47bb-0310-9956-ffa450edef68
@dixitdeepak
Improved: Added unit test case for following party related services
1a0a58f 
- lookupParty
- getPartyEmail
- createAffiliate, updateAffiliate
- getPartyMainRole
- getPartyTelephone
- quickCreateCustomer
- createAddressMatchMap, removeAddressMatchMap, clearAddressMatchMap
- createPartyInvitation, updatePartyInvitation, deletePartyInvitation
- getPartyPostalAddress, 
- createPartyContactMechPurpose
- createEmailAddressVerification
- createPartyInvitationRoleAssoc, deletePartyInvitationRoleAssoc
- updatePostalAddressAndPurposes
- createPartyInvitationGroupAssoc, deletePartyInvitationGroupAssoc
(OFBIZ-8669)(OFBIZ-8626)(OFBIZ-8627)(OFBIZ-8628)(OFBIZ-8629)(OFBIZ-8630)(OFBIZ-8631)(OFBIZ-8632)(OFBIZ-8633)(OFBIZ-8634)(OFBIZ-8635)
(OFBIZ-8636)(OFBIZ-8637)(OFBIZ-8638)(OFBIZ-8639)(OFBIZ-8640)OFBIZ-8642)(OFBIZ-8643)(OFBIZ-8644)(OFBIZ-8645)(OFBIZ-8646)

Thanks Akash Jain and Pawan Verma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767968 13f79535-47bb-0310-9956-ffa450edef68
@dixitdeepak
Improved: Added unit test case for following accounting related services
0949f19 
- createFinAccount
- updateFinAccount
- deleteFinAccount
- createFinAccountStatus
- createFinAccountTrans
- createFinAccountRole
- updateFinAccountRole
-  deleteFinAccountRole
(OFBIZ-8814)(OFBIZ-8815)(OFBIZ-8816)(OFBIZ-8817)(OFBIZ-8818)(OFBIZ-8819)(OFBIZ-8820)(OFBIZ-8821)

Thanks Deepak Nigam for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767972 13f79535-47bb-0310-9956-ffa450edef68
@dixitdeepak
Improved: Added missing file for accounting fin service test cases.
fefde07 
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767974 13f79535-47bb-0310-9956-ffa450edef68
@dixitdeepak
Improved: Added unit test case for following product related services
530fd28 
- createProduct, updateProduct
- duplicateProduct
- quickAddVariant
- deleteProductKeywords
- discontinueProductSales
- createProductReview
- updateProductReview
- findProductById
- createProductPrice, updateProductPrice, deleteProductPrice
- createProductCategory
(OFBIZ-8412)(OFBIZ-8506)(OFBIZ-8571)(OFBIZ-8654)(OFBIZ-8572)(OFBIZ-8573)(OFBIZ-8574)
(OFBIZ-8656)(OFBIZ-8575)(OFBIZ-8576)(OFBIZ-8577)(OFBIZ-8578)(OFBIZ-8655)

Thanks Akash Jain and Yash Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767977 13f79535-47bb-0310-9956-ffa450edef68
Implemented: Added CRUD services for ProductAverageCostType, ProductC…
802ffb1 
…ategoryContentType, ProductCategoryType, ProductCategoryTypeAttr, ProductContentType, ProductFeatureApplType, ProductFeatureIactnType, ProductMaintType, ProductMeterType, ProductOrderItem, ProductPriceActionType, ProductPriceAutoNotice, ProductStoreGroupType, ProductType, ProductTypeAttr and StatusType entities. Also converted services of ContactMechLink to entity-auto.

(OFBIZ-8731)(OFBIZ-8732)(OFBIZ-8733)(OFBIZ-8734)(OFBIZ-8735)(OFBIZ-8736)(OFBIZ-8737)(OFBIZ-8762)(OFBIZ-8763)(OFBIZ-8764)(OFBIZ-8765)(OFBIZ-8766)(OFBIZ-8771)(OFBIZ-8772)(OFBIZ-8773)(OFBIZ-8774)(OFBIZ-8807)

Thanks: Rahul Singh, Chinmay Patidar, Rohit Koushal and Rishi Solanki for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768080 13f79535-47bb-0310-9956-ffa450edef68
Fixed: Page bottom navigation problem with grid and include-grid
b962c70 
(OFBIZ-7648)

Thanks: Rohit Koushal and Rishi Solanki for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768150 13f79535-47bb-0310-9956-ffa450edef68
Fixed: Moved CRUD service of PaymentMethodType in specific file.
eac7411 
(OFBIZ-8648)

Thanks: Jacques for reviewing and reporting.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768151 13f79535-47bb-0310-9956-ffa450edef68
Fixed: Moved delete service of ProductStoreGroupRollup near to create…
14b231a 
… and update service.

(OFBIZ-8770)

Thanks: Jacques for reviewing and reporting.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768152 13f79535-47bb-0310-9956-ffa450edef68
Fixed: Arranged sequence of CRUD services to make consistency.
8d3005d 
(OFBIZ-8461)

Thanks: Jacques for reviewing and reporting.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768154 13f79535-47bb-0310-9956-ffa450edef68
@dixitdeepak
Improved: Convert ShipmentContactMech entity CRUD service to entity-a…
c683594 
…uto, applied slightly modify patch from jira issue.

(OFBIZ-8895)

Thanks Pawan Verma for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768157 13f79535-47bb-0310-9956-ffa450edef68
@dixitdeepak
Improved: Added test cases for following rate related servicse.
6d44aff 
- getRateAmount
- deleteRateAmount
- updateRateAmount
- getRatesAmountsFromWorkEffortId
- getRatesAmountsFromPartyId
- getRatesAmountsFromEmplPositionTypeId
- updatePartyRate
- deletePartyRate
- filterRateAmountList

(OFBIZ-8747)(OFBIZ-8753)(OFBIZ-8754)(OFBIZ-8755)(OFBIZ-8756)(OFBIZ-8757)(OFBIZ-8758)(OFBIZ-8759)(OFBIZ-8760)(OFBIZ-8761)

Thanks Akash Jain and Pawan Verma for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768162 13f79535-47bb-0310-9956-ffa450edef68
Implemented: Added CRUD services for TestingSubtype,TestingType, User…
10de25c 
…AgentType, UserAgentMethodType, FinAccountRole, BrowserType, PlatformType, ProtocolType, ServerHitType, UserAgent, FinAccount, FinAccountTypeGlAccount, VarianceReasonGlAccount, FixedAssetTypeGlAccount, InvoiceTerm, InvoiceContactMech, InvoiceContent entities.

(OFBIZ-8785)(OFBIZ-8786)(OFBIZ-8790)(OFBIZ-8791)(OFBIZ-8805)(OFBIZ-8834)(OFBIZ-8835)(OFBIZ-8836)(OFBIZ-8837)(OFBIZ-8839)(OFBIZ-8881)(OFBIZ-8888)(OFBIZ-8892)(OFBIZ-8894)(OFBIZ-8916)(OFBIZ-8923)(OFBIZ-8928)

Thanks: Rahul Singh, Rohit Koushal, Amit Gadalay and Rishi Solanki for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768163 13f79535-47bb-0310-9956-ffa450edef68
Fixed: Converted Update service of ShipmentGatewayConfig and Shipment…
61a0454 
…GatewayConfigType into entity-auto.

(OFBIZ-8454)(OFBIZ-8455)

Thanks: Jacques for reporting issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768166 13f79535-47bb-0310-9956-ffa450edef68
@dixitdeepak
Improved: Corrected sequence of FinAccount test cases, as it delete t…
00c9852 
…he rule in one case and in next case it try to update the deleted data. Now it will fixed the test case failing issue.

 
(OFBIZ-8814)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768167 13f79535-47bb-0310-9956-ffa450edef68
Fixed: Catch GenericEntityException and GenericServiceException and o…
2b863d1 
…ther instead of Exception in Java classes.

(OFBIZ-8909)(OFBIZ-8910)(OFBIZ-8911)(OFBIZ-8912)(OFBIZ-8913)(OFBIZ-8914)(OFBIZ-8915)(OFBIZ-8917)(OFBIZ-8918)(OFBIZ-8919)(OFBIZ-8920)(OFBIZ-8921)(OFBIZ-8922)

Thanks: Divesh Dutta for reporting and Amit Gaadaley for providing patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768168 13f79535-47bb-0310-9956-ffa450edef68
New Feature: Introduce a quick way for adding Sales Price agreements …
4c1b1c2 
…with customers for any specific product from Catalog

(OFBIZ-7713)

Thanks: Swapnil Shah for suggesting this new featuer and Mohammad Kathawala for giving the patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768174 13f79535-47bb-0310-9956-ffa450edef68
@dixitdeepak
Improved: Added test cases for createFinAccountAuth and setFinAccount…
b7fe441 
…TransStatus service.

(OFBIZ-8832)(8833)

Thanks Deepak Nigam for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768175 13f79535-47bb-0310-9956-ffa450edef68
JacquesLeRoux and others added 29 commits January 31, 2017 14:07
@JacquesLeRoux
Improved: Implement and demonstrate few services in Birt Report Builder
6d04d09 
(OFBIZ-9192)

The Birt Report Builder can also use services. for now only the "rotation" 
report as been provided. We can provide more examples based on François' 
work. 

Here are trivial changes
  fixes missing Lookup maps and view in controller for the "rotation" report 
  new needed labels
  typos fixed
  


Thanks:

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781084 13f79535-47bb-0310-9956-ffa450edef68
@jacopoc
Fixed: reversed the debit and credit entries of the accounting transa…
aeaaf7c 
…ctions for

fixed asset depreciations.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781109 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
Fixed: Navigate Accounts tree does not work
272e1a1 
(OFBIZ-9191)

This is due to a change in (at least) Tomcat 8.0.39

Here is a simple fix. I tried other ways but none worked and I prefer to keep
this simple.
I tried other ways but none worked and I prefer to keep this simple.
* Using an encoder at this stage (just before calling the macro) is not an 
option. Or maybe by using the encoder on the linkurl variable alone. 
But then linkurl  must be transformed in a String and  back to a 
StringBuilder or more refactoring is needed. It does not worth it IMO.
* Also using encode="true" for links in AccountingTrees.xml does not work.

This also removes trailing blanks (by hand)

Thanks: Moatasim Al Masri for report


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781125 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
No functional change, removes useless <fail-widgets/> element
fb2062d 
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781202 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
No functional change, removes useless line
5441c92 
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781209 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
No functional changes
571bfc1 
Adds a missing BirtOverrideFilters label
Fixes a typo in BirtServices.java and organise imports
Change a button name in BirtForms.xml
Uses the BirtOverrideFilters label in BirtScreens.xml

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781215 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
Fixed: After creating a new Flexible Birt report, before visualising …
9acf14f 
…it you need

 to do other actions
(OFBIZ-9194)

You need to add the data set fields with the Birt Report Designer 
and publish the report. This will be documented with OFBIZ-9188

I thought about graying the button but it was a delicate matter because it uses
a <content element in screen and directly call a view handled from a Groovy 
event.

It was easier to fix the PrepareBirtCall Groovy event. But to be totally sure
I also handled the possible NPE in the BirtViewHandler

I also fixed viewLast error in controller 

Because the files were not committed with the svn:eol-style native property
you will see false changes in this commit. Some files have their svn:eol-style 
native property set. I'll soon commit missing so in new Birt Java files.

I'll also commit a lot of svn:eol-style native property changes for XML and 
Groovy files which have been neglected so far. I'm sorry for that because 
when we do so we loose the annotations history. I will then definitely put in 
place what I suggested in http://markmail.org/message/ffmyw773p65fndey

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781218 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
No functional changes
42a720c 
At http://markmail.org/message/ffmyw773p65fndey I wrote:

I'd like to follow the suggestion I made in the last message of the linked 
thread.
In other words, use
http://subversion.apache.org/docs/release-notes/1.8.html#repos-dictated-config
http://blogs.collab.net/subversion/the-road-to-repository-dictated-configuration-day-2-autoprops
Then this problem would be over. No longer need to check from time to time that
concerned files, have svn:eol-style=native property set
This imply that all OFBiz users use svn > 1.7, but we can inform them, et voilà

Then at markmail.org/message/h3q2yvj4db544ro7 I wrote:

Actually, since we get new committers now and then and their are able to create
new files I have a warning every 6 months which says "Check Java 
files, have all svn:eol-style=native" (I totally forgot that because I assume
the machine knows it and warns me ;))
I could extend that to all files (at least the most prominent types), I'll
see...

This does what the last sentence said for Groovy, XML and few new Birt 
Java files.

I'll see if I can implement the svn 1.8 repos-dictated-config ASAP!




git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781219 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
Implemented:
91c44aa 
Improved:
Documented:
Completed:
Reverted:
Fixed:
(OFBIZ-)
Explanation
Thanks:

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781366 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
No functional change, reverts r1781366
7d7578c 
I did not even notice I committed this bunch of WIP stuff. I guess I clicked 
somewhere while my machine was too buzy

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781367 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
No functional change, removes useless return in Javadoc
e7e2331 
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781431 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
No functional change. Tries to set the svn:auto-props on OFBiz svn re…
9497a38 
…po root

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781441 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
No functional change. We no longer need the svn:auto-props at this le…
0d24121 
…vel, it's

now set at OFBiz svn repo root level


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781446 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
Fixed: Missing file results in error
30013a4 
(OFBIZ-9198)

When accessing a file/image in ecomseo (only seo version) that is physically 
missing or the dataresource attribute isPublic=="N" the request results 
in a loop.

jleroux: to break the loop in case or error, I simply decided to return a 
response of type none. I also added the same for io-error which can be returned
by the DataEvents class, also in ecommerce controller

Thanks: Ingo Wolfmayr for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781662 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
No functional changes
1a07db6 
completes r1781219 by putting svn:eol-style=native to all file types declared 
in [auto-props] section of the svn config files.css

Actually this is only a 1st pass, it was too complicated to do it for  
all file types at once only concerned here
*.java;*.bsh;*.groovy;*.jsp;*.tld;*.ftl;*.js;*.sql;*.c;*.cpp;*.h;*.txt;*.sgml;
*.properties;*.xml;.classpath;.project;*.sld;*.gml;*.xsl;*.xsd
*.html;*.htm;*.css;*.md;README;NOTICE;LICENSE;rc.ofbiz.*;*.less;*.dsp;*.dsw

Most files should not be concerned by this change, but it's impossible to do
it one by one.

There are also changes in files with have mixed EOLs; because this has no sense
when using native which automatically resolves this issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781731 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
No functional changes
a7eb147 
Completes r1781731 by putting svn:eol-style=native to *.sh;*.bat file types 

There are also changes in files with have mixed EOLs because this is no sense
when using native which automatically resolves this issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781735 13f79535-47bb-0310-9956-ffa450edef68
@mbrohl
Fixed: Cancelled OrderItems are still included in orderGrandTotal.
e15f444 
(OFBIZ-9204)

Thanks: Maurice for reporting and providing the patch, Deepak and Jacques for their suggestions.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781979 13f79535-47bb-0310-9956-ffa450edef68
@nmalin
Fixed: Birt logging unlogical high (OFBIZ-9201)
7bfa662 
Currently the class BirtContainer call the birt engine with hard coded log level ALL that generated huge log file.
We can't implement easily log4j on the birt engine so with this commit I create a quick fix to have matching between the java.util.Logger and org.apache.log4j.Logger level.
You can select the log level from debug.properties to populate the ReportEngine log file.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782070 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
Fixed: SimpleMethod: FindByAnd never using EntityListIterator
deeb329 
(OFBIZ-9152)

Since the introduction of EntityQuery there was no distinction between a simple 
method tags 
<find-by-and use-iterator="true"> and <find-by-and use-iterator="false"> 
(except cache handling).
There is a condition "if (useIterator)" but with entityQueries did use 
"[...].queryList()".

Thanks: Mirko Vogelsmeier

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782498 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
Fixed: Reinstate url cache in UtilURL.fromResource
1656df2 
(OFBIZ-9208)

Adrian created the following commit to cache URL objects 


Revision: 1649979
Author: adrianc
Date: 07 January 2015 00:24:28
Message:
Some optimizations for URL lookups.
----
Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilProperties.java
Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java

and was later reverted in this commit

Revision: 1650347
Author: adrianc
Date: 08 January 2015 17:53:59
Message:
Some small fixups for some of my previous commits.
----
Modified : /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityClassLoader.java
Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java

We have found in one of our production servers that line 98 in UtilURL.java

url = loader.getResource(resourceName);

has caused locking and looking at the stack trace (from jstack). There are 
numerous threads waiting on locks from within this method

I propose the cache gets added back (we have done this as a patch on our systems
 with no ill effect)

FYI - The commits are in reference to the EntityClassLoader which is not used 
and does not work see OFBIZ-6210

Thanks: Gareth Carter for report and suggestion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782520 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
Improved: refactor list related forms in Agreeement widgets
208af37 
(OFBIZ-9186)

Refactoring various list forms into grids
Refactoring various list form references in screens

Thanks: Pierre Smits

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782562 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
Implemented: Load demo data shows error loading xml files
6cb9356 
Fixed:
(OFBIZ-9211)

"gradlew cleanAll loadDefault" generates a data loading error

It's logically due to the removing of plugins/component-load.xml in OFBIZ-9182
A temporary solution is to put it in again. 
A definitive solution is to remove data dependencies. 
We have also this problem with ecommerce data which create dependencies 
from applications

jleroux: I don't close this issue yet because we need to work together on this.
I simply remove the regression by putting back plugins/component-load.xml

Thanks: Wai for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782577 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
No functional change, last update with less Vulnerable Dependencies
fb129c1 
Only higher will be considered, not done yet...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782603 13f79535-47bb-0310-9956-ffa450edef68
@JacquesLeRoux
No functional change, updates and removes some now useless files
82e1edc 
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782604 13f79535-47bb-0310-9956-ffa450edef68
@pythys
Implemented: new gradle task pullPluginSource using a subversion grad…
e25363d 
…le plugin

(OFBIZ-9182)

Added a new gradle task called pullPluginSource that fetches a plugin from
the (yet to be created) plugins repository. Also updated the README.md file
to reflect the changes that happened recently on the plugin management tasks

This is the last commit required before restructuring the subversion repository
as per the discussion thread mentioned in the above JIRA


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782605 13f79535-47bb-0310-9956-ffa450edef68
@dixitdeepak
Improved: Moves plugins and creates the new structure (OFBIZ-9182)
7ba7f3c 
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782651 13f79535-47bb-0310-9956-ffa450edef68
[OFBIZ-10934] Replace replaceAll() with replace() when not usng regex
0aa2cb7
[OFBIZ-10934] Replaced more instances of replaceAll() with replace() …
da4aed2 
…when not using regex
[OFBIZ-10934] Replaced more instances of replaceAll() with replace().
5262850
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.