-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][fn] ack messages for window function when its result is null #23618
Merged
shibd
merged 1 commit into
apache:master
from
jiangpengcheng:fix_ack_for_window_function
Nov 22, 2024
Merged
[fix][fn] ack messages for window function when its result is null #23618
shibd
merged 1 commit into
apache:master
from
jiangpengcheng:fix_ack_for_window_function
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
added
ready-to-test
type/bug
The PR fixed a bug or issue reported a bug
release/3.3.3
release/3.0.8
release/4.0.1
labels
Nov 21, 2024
/pulsarbot rerun-failure-checks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23618 +/- ##
============================================
+ Coverage 73.57% 74.39% +0.82%
- Complexity 32624 34469 +1845
============================================
Files 1877 1944 +67
Lines 139502 147134 +7632
Branches 15299 16226 +927
============================================
+ Hits 102638 109467 +6829
- Misses 28908 29233 +325
- Partials 7956 8434 +478
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jiangpengcheng
force-pushed
the
fix_ack_for_window_function
branch
from
November 21, 2024 07:18
d29d6e8
to
a27e08d
Compare
jiangpengcheng
changed the title
[fix][fn] Fix ack logic for window functions
[fix][fn] ack messages for window function when its result is null
Nov 21, 2024
/pulsarbot rerun-failure-checks |
shibd
approved these changes
Nov 21, 2024
nlu90
approved these changes
Nov 22, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 26, 2024
…pache#23618) (cherry picked from commit 024ff75) (cherry picked from commit 510ac3b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.8
release/3.3.3
release/4.0.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23617
Main Issue: #xyz
PIP: #xyz
Motivation
The window function doesn't handle ack correctly
Modifications
Verifying this change
Make sure that the change passes the CI checks.
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: jiangpengcheng#34