Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][fn] ack messages for window function when its result is null #23618

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

jiangpengcheng
Copy link
Contributor

@jiangpengcheng jiangpengcheng commented Nov 21, 2024

Fixes #23617

Main Issue: #xyz

PIP: #xyz

Motivation

The window function doesn't handle ack correctly

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

  • This change is already covered by existing tests, such as (please describe tests).

    • org.apache.pulsar.tests.integration.functions.java.testTumblingCountWindowTest
    • org.apache.pulsar.tests.integration.functions.java.testSlidingCountWindowTest

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: jiangpengcheng#34

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 21, 2024
@nlu90 nlu90 requested a review from shibd November 21, 2024 04:18
@shibd
Copy link
Member

shibd commented Nov 21, 2024

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.39%. Comparing base (bbc6224) to head (a27e08d).
Report is 743 commits behind head on master.

Files with missing lines Patch % Lines
...ar/functions/windowing/WindowFunctionExecutor.java 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23618      +/-   ##
============================================
+ Coverage     73.57%   74.39%   +0.82%     
- Complexity    32624    34469    +1845     
============================================
  Files          1877     1944      +67     
  Lines        139502   147134    +7632     
  Branches      15299    16226     +927     
============================================
+ Hits         102638   109467    +6829     
- Misses        28908    29233     +325     
- Partials       7956     8434     +478     
Flag Coverage Δ
inttests 27.51% <0.00%> (+2.92%) ⬆️
systests 24.33% <0.00%> (+0.01%) ⬆️
unittests 73.78% <0.00%> (+0.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ar/functions/windowing/WindowFunctionExecutor.java 66.43% <0.00%> (-1.92%) ⬇️

... and 663 files with indirect coverage changes

---- 🚨 Try these New Features:

@jiangpengcheng jiangpengcheng changed the title [fix][fn] Fix ack logic for window functions [fix][fn] ack messages for window function when its result is null Nov 21, 2024
@jiangpengcheng
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@shibd shibd merged commit 024ff75 into apache:master Nov 22, 2024
54 checks passed
shibd pushed a commit that referenced this pull request Nov 22, 2024
shibd pushed a commit that referenced this pull request Nov 22, 2024
shibd pushed a commit that referenced this pull request Nov 22, 2024
lhotari added a commit that referenced this pull request Nov 22, 2024
- fixes a cherry-picking issue in commit 510ac3b which cherry-picked #23618 to branch-3.0
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] window functions ack messages directly when they comes, which is not expected
5 participants