Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Upgrade pyarrow to 18.1.0 #31476

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

phillipleblanc
Copy link

SUMMARY

Upgrade pyarrow to 18.1.0, to support the StringView arrow type.

TESTING INSTRUCTIONS

Start Superset and verify that the SQL Lab queries are still working.

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Update PyArrow dependency to support StringView type #31475
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.75%. Comparing base (76d897e) to head (d451881).
Report is 1218 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #31476       +/-   ##
===========================================
+ Coverage   60.48%   83.75%   +23.26%     
===========================================
  Files        1931      538     -1393     
  Lines       76236    39128    -37108     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32772    -13342     
+ Misses      28017     6356    -21661     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.75% <ø> (-0.41%) ⬇️
javascript ?
mysql 76.51% <ø> (?)
postgres 76.57% <ø> (?)
presto 53.27% <ø> (-0.54%) ⬇️
python 83.75% <ø> (+20.26%) ⬆️
sqlite 76.03% <ø> (?)
unit 60.88% <ø> (+3.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a biiiig bump, fingers crossed this doesn't break anything. But I assume we should have adequate coverage to protect against these types of upgrade regressions.

pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing to "Request changes" to update the dependency bounds.

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@phillipleblanc
Copy link
Author

@villebro I've updated the dependency bounds

@rusackas
Copy link
Member

Running CI 🤞

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update requirements/development.txt, too, as that is pinning pyarrow==14.0.2. Optimally, you should run the uv commands for this.

@phillipleblanc
Copy link
Author

Thanks, I've run the uv command to update both requirements/base.txt and requirements/development.txt.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - it appears the docker build step is failing, but I believe it's unrelated. I'll try to restart CI, but it may well be that something needs to be fixed on master before we can get this working..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PyArrow dependency to support StringView type
3 participants