-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIR][CUDA] Add native FP8 support to codegen #16548
Merged
csullivan
merged 17 commits into
apache:main
from
csullivan:feature/2024-02-08/cuda_native_fp8
Mar 15, 2024
Merged
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
fba5103
[TIR][CUDA] Add native FP8 support to codegen
csullivan eb4ca30
Add test for e4m3 <-> half conversion which lowers to ptx intrins."
csullivan a8560de
Use _2/_4 in vector types
csullivan 919ed3c
Introduce half4 and support native fp8 vector types (1, 2, 4), and
csullivan ffe3562
Lint: blacken
csullivan 07a69d6
Handle vectorized float16 types using native half struct types.
csullivan 843e3f0
Update numerical checks on
csullivan ce78dd3
Update numerical checks on
csullivan 490f506
Reproduced end-to-end fp8 quantization as a unit test to diagnose ill…
csullivan 7f44f1d
Fix striding bug in quantize kernel
csullivan 88eae45
Fix striding bug in dequantize kernel
csullivan 901fd0b
Add dequantize flow so that we round trip
csullivan 21566a4
[Transform] unsupported_dtype_legalize.cc - Only check cuda compute v…
csullivan b97081d
[BF16] The BF16ComputeLegalizer expects to be run in lowering to
csullivan 426f09e
Remove check for undefined llvm type.
csullivan f2bc4b4
Only cast to half2 for vector loads/stores of non native half struct …
csullivan dbbf15c
[FP8] Test e4m3 x4 vector quant/dequant
csullivan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this breaks CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vinx13. I was trying to leave the code better than I found it, but I guess some downstream handling is relying on this behavior. I have removed the check.