[Relax] CUDA graph rewrite treating StringImm as static #16691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinx13
approved these changes
Mar 9, 2024
tqchen
approved these changes
Mar 9, 2024
The RewriteCUDAGraph pass missed to consider StringImm as a static expression, causing some loss of CUDA graph rewrite opportunities. This PR fixes the issue.
MasterJH5574
force-pushed
the
tvm-dev/2024-03-08-cuda-graph
branch
from
f341532
to
89a73f0
Compare
Lunderberg
pushed a commit
to Lunderberg/tvm
that referenced
this pull request
Mar 12, 2024
The RewriteCUDAGraph pass missed to consider StringImm as a static expression, causing some loss of CUDA graph rewrite opportunities. This PR fixes the issue.
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
The RewriteCUDAGraph pass missed to consider StringImm as a static expression, causing some loss of CUDA graph rewrite opportunities. This PR fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RewriteCUDAGraph pass missed to consider StringImm as a static expression, causing some loss of CUDA graph rewrite opportunities. This PR fixes the issue.
Choosing not to add a regression test considering this is a very trivial change.