Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Allow deprecated API requestAdapterInfo with any cast #17420

Merged
merged 3 commits into from
Sep 28, 2024
Merged

[Web] Allow deprecated API requestAdapterInfo with any cast #17420

merged 3 commits into from
Sep 28, 2024

Conversation

CharlieFRuan
Copy link
Contributor

@CharlieFRuan CharlieFRuan commented Sep 26, 2024 •
edited
Loading

The WebGPU API requestAdapterInfo() was deprecated as described here: https://developer.mozilla.org/en-US/docs/Web/API/GPUAdapter/requestAdapterInfo#browser_compatibility. This caused npm run build under web/ to cause error since it cannot find requestAdapterInfo, hence the PR: #17371

However, downstream users may still have older browser version and would still rely on requestAdapterInfo(), see mlc-ai/web-llm#572 for an example.

This PR casts adapter to any type when calling requestAdapterInfo(), so it does not complain about not being able to find requestAdapterInfo() during compile time, hence no issue should be observed during runtime on older browsers, achieving backward compatibility.

Bump TVMjs version from 0.18.0-dev0 to 0.18.0-dev2 (skipped dev1 due to a mistake)

@CharlieFRuan CharlieFRuan mentioned this pull request Sep 26, 2024
Merged
CharlieFRuan added a commit to mlc-ai/web-llm that referenced this pull request Sep 26, 2024
@CharlieFRuan
[TVMjs] Bump TVMjs version to fix WebGPU backward compatibility (#580)
79ce88f 
This PR bumps TVMjs (i.e. `@mlc-ai/web-runtime`) from `0.18.0-dev0` to
`0.18.0-dev1`.

The only change is:
- apache/tvm#17420

TVMjs `0.18.0-dev1` is compiled at
apache/tvm@5e85443
with apache/tvm#17420 cherry-picked on top
 
This should fix:
- #572
@CharlieFRuan CharlieFRuan mentioned this pull request Sep 26, 2024
Merged
CharlieFRuan added a commit to mlc-ai/web-llm that referenced this pull request Sep 26, 2024
@CharlieFRuan
[Version] Bump version to 0.2.70 (#581)
a373a4d 
### Change
- #580
- Bumps TVMjs version to fix
#572

### TVMjs
Updated TVMjs to `0.18.0-dev1`, compiled at
apache/tvm@5e85443
with apache/tvm#17420 cherry-picked on top
- The only diff is apache/tvm#17420
@CharlieFRuan CharlieFRuan marked this pull request as draft September 27, 2024 05:40
@CharlieFRuan CharlieFRuan marked this pull request as ready for review September 27, 2024 06:19
@CharlieFRuan CharlieFRuan mentioned this pull request Sep 27, 2024
Merged
CharlieFRuan added a commit to mlc-ai/web-llm that referenced this pull request Sep 27, 2024
@CharlieFRuan
[Version] Bump version to 0.2.71 (#583)
e92f21e 
### Change

- This version tries to solve the same issue in `0.2.70`, which bumped
TVMjs from `0.18.0-dev0` to `0.18.0.dev1`
- This version bumps from `0.18.0.dev1` to `0.18.0.dev2`
- The previous issue described in
#581 was not resolved as
apache/tvm#17420 missed an `await`.
`0.18.0.dev2` resolves this. Confirmed in an older version of Brave
browser: `Version 1.65.133 Chromium: 124.0.6367.208 (Official Build)
(arm64)`

### TVMjs
- Updated TVMjs to `0.18.0-dev2`, compiled at
apache/tvm@5e85443
with apache/tvm#17420 cherry-picked on top
- The only diff is apache/tvm#17420
@CharlieFRuan
Copy link
Contributor Author

@tvm-bot rerun

@tqchen tqchen merged commit 7ff4d0d into apache:main Sep 28, 2024
15 of 17 checks passed
@ysh329
Copy link
Contributor

ysh329 commented Oct 8, 2024 •
edited
Loading

Hi @CharlieFRuan , recently release starts, but I found WebGPU part has some modification about version number. Is it required to change version in web/package-lock.json with same version number?

Each modification includes fixed five file modifications: #17156. If there are any modifications related to web/package-lock. json, I will add them to the document and make the necessary changes this time if requied.

@CharlieFRuan
Copy link
Contributor Author

Hi @ysh329, thanks for the note! Just to check my understanding, does the version in web/package-lock.json have to match all five files, including the dev suffix?

@ysh329
Copy link
Contributor

ysh329 commented Oct 9, 2024 •
edited
Loading

@CharlieFRuan I think it's better keep same between dev suffix in web/package-lock.json and other five files. Besides, I wann know in this patch why change the dev0 to dev2, but not dev1?

@CharlieFRuan
Copy link
Contributor Author

CharlieFRuan commented Oct 9, 2024 •
edited
Loading

@ysh329 I see, then I think it's easier for me to revert the version in web/package-lock.json. Shall I make a PR to revert back to 0.18.0-dev0? Thanks

@ysh329
Copy link
Contributor

ysh329 commented Oct 10, 2024

@CharlieFRuan Don't worry. Let me fix this minor problem.

@CharlieFRuan
Copy link
Contributor Author

Thanks a lot!

This was referenced Oct 11, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CharlieFRuan @ysh329 @tqchen