[YUNIKORN-2887] Optimize sortApplications function code (#974)

Closes: #974 Signed-off-by: Craig Condit <ccondit@apache.org>
apache · Sep 24, 2024 · fe067b7 · fe067b7
1 parent 46ce58d
commit fe067b7
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/pkg/scheduler/objects/sorters.go b/pkg/scheduler/objects/sorters.go
@@ -100,17 +100,15 @@ func sortQueuesByFairnessAndPriority(queues []*Queue, fairMaxResources []*resour
 
 func sortApplications(apps map[string]*Application, sortType policies.SortPolicy, considerPriority bool, globalResource *resources.Resource) []*Application {
 	sortingStart := time.Now()
-	var sortedApps []*Application
+	sortedApps := filterOnPendingResources(apps)
 	switch sortType {
 	case policies.FairSortPolicy:
-		sortedApps = filterOnPendingResources(apps)
 		if considerPriority {
 			sortApplicationsByPriorityAndFairness(sortedApps, globalResource)
 		} else {
 			sortApplicationsByFairnessAndPriority(sortedApps, globalResource)
 		}
 	case policies.FifoSortPolicy:
-		sortedApps = filterOnPendingResources(apps)
 		if considerPriority {
 			sortApplicationsByPriorityAndSubmissionTime(sortedApps)
 		} else {