[YUNIKORN-2965] Move statedump and stack REST to debug endpoint #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The REST calls to get a statedump and the stacks of the system are exposed on the wrong endpoint. They belong in /debug and not in /ws/v1. Both are for troubleshooting only and the content is not stable. Placing a 301 redirect on the old endpoints for clients to follow. The proxy build into the web UI does not proxy the debug endpoints.
wilfred-s
requested review from
lixmgl,
craigcondit,
yangwwei,
pbacsko and
chenyulin0719
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #992 +/- ##
==========================================
+ Coverage 81.50% 81.75% +0.25%
==========================================
Files 97 97
Lines 15520 15531 +11
==========================================
+ Hits 12649 12698 +49
+ Misses 2592 2554 -38
Partials 279 279 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The REST calls to get a statedump and the stacks of the system are exposed on the wrong endpoint. They belong in /debug and not in /ws/v1. Both are for troubleshooting only and the content is not stable.
Placing a 301 redirect on the old endpoints for clients to follow. The proxy build into the web UI does not proxy the debug endpoints.
What type of PR is it?
[X] - Bug Fix
Todos
[X] - Documentation update
[X] - e2e test update to call /debug/fullstatedump
What is the Jira issue?
YUNIKORN-2965
How should this be tested?
unit tests provided, e2e will follow redirect