-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support log file based positioning replication (to #155) #156
Conversation
4cf2c18
to
0fab8cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This will enable potential users to connect to existing MySQL deployments without enabling the GTID mode. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
70b1143
to
dfb7a41
Compare
I noticed you have injected the gtid_mode related code into the test code. IMO this is unnecessary and makes the test code harder to maintain (as it becomes significantly out-of-sync with Dolt's test). Since the tests are executed by starting a primary MySQL container and a MyDuck executable, you can just add a global environment variable for testing and according to which you can start the primary MySQL/MariaDB container in different mode. |
e8968f0
to
f55cc77
Compare
Sounds reasonable |
f55cc77
to
24f8b53
Compare
24f8b53
to
9bdf0e7
Compare
This PR address the issue #155. It mainly add the supporting of file log based replication for MyDuck Server.