Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support log file based positioning replication (to #155) #156

Merged
merged 7 commits into from
Nov 15, 2024

Conversation

VWagen1989
Copy link
Contributor

This PR address the issue #155. It mainly add the supporting of file log based replication for MyDuck Server.

binlogreplication/binlog_replica_applier.go Outdated Show resolved Hide resolved
binlogreplication/binlog_replica_applier.go Outdated Show resolved Hide resolved
devtools/replica-setup/checker.sh Outdated Show resolved Hide resolved
binlogreplication/binlog_replica_applier.go Show resolved Hide resolved
binlogreplication/binlog_replica_applier.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@fanyang01 fanyang01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This will enable potential users to connect to existing MySQL deployments without enabling the GTID mode. Thanks!

Copy link
Contributor

@TianyuZhang1214 TianyuZhang1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VWagen1989 VWagen1989 force-pushed the log_pos_replication branch 5 times, most recently from 70b1143 to dfb7a41 Compare November 15, 2024 08:52
@fanyang01
Copy link
Collaborator

fanyang01 commented Nov 15, 2024

I noticed you have injected the gtid_mode related code into the test code. IMO this is unnecessary and makes the test code harder to maintain (as it becomes significantly out-of-sync with Dolt's test). Since the tests are executed by starting a primary MySQL container and a MyDuck executable, you can just add a global environment variable for testing and according to which you can start the primary MySQL/MariaDB container in different mode.

@VWagen1989
Copy link
Contributor Author

I noticed you have injected the gtid_mode related code into the test code. IMO this is unnecessary and makes the test code harder to maintain (as it becomes significantly out-of-sync with Dolt's test). Since the tests are executed by starting a primary MySQL container and a MyDuck executable, you can just add a global environment variable for testing and according to which you can start the primary MySQL/MariaDB container in different mode.

Sounds reasonable

@VWagen1989 VWagen1989 enabled auto-merge (squash) November 15, 2024 10:33
@VWagen1989 VWagen1989 merged commit 8c7543c into main Nov 15, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants