Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Xcode 12 & SPM #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ArnaudWurmel
Copy link

Hello,

As we are using this framework for our application, and we are migrating from Carthage to SwiftPM, I looked at the issue #7 and the work from @alizx.

Some architectural changes were required to make it work but I tried as much as possible to not modify the code that you did.

This PR isn't supporting Carthage anymore since I couldn't find something to make it work. If anyone is interested to make the Carthage support, I would gladly update my PR with his modifications.

The iOSTestApp (that only import the framework to try the compilation) is not included anymore as it's much more complicated to import the SPM framework in a local app and the gain provided is very low.

The project must be splitted because SPM doesn't support mixed language for a same target.
So I went for these three targets:

SwiftZSTD: Containing all the Swift source codes
SwiftZSTDC: Containing the OBJ-C source code
zstdlib: Containg the C library

SwiftZSTDC is depending on zstdlib target and SwiftZSTD is depending on both zstdlib and SwiftZSTDC targets.

Finally, the targets are grouped into the same library file (SwiftZSTD).

Additionally, I updated the zstdlib to its latest version (1.5.0).

If you have any comment about this issue, feel free to contact me, I will make the required modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant