fix(laravel): jsonapi query parameters (page, sort, fields and include) #6876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
soyuka
commented
Dec 17, 2024
soyuka
commented
| Q | A |
|---|---|
| Branch? | 4.0 (this feature should be supported by Laravel) |
| Tickets | Closes #6841 |
| License | MIT |
soyuka
force-pushed
the
fix/jsonapi-query-parameters
branch
3 times, most recently
from
9911444 to
c941431
Compare
dunglas
approved these changes
Dec 19, 2024
|
|
||
| public function getOpenApiParameters(MetadataParameter $parameter): Parameter|array|null | ||
| { | ||
| $example = \sprintf( |
There was a problem hiding this comment.
This variable seems useless, you could likely have a single sprintf
soyuka
force-pushed
the
fix/jsonapi-query-parameters
branch
from
c941431 to
6992e5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.