Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor accessor warnings #12143

Closed
wants to merge 20 commits into from
Closed

Refactor accessor warnings #12143

wants to merge 20 commits into from
+587 −564

Commits on Nov 18, 2024

  1. Use Object.assign when handling inline fragments

    @jerelmiller
    jerelmiller committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    220ad82 View commit details
    Browse the repository at this point in the history

  2. Move iteration into main maskSelectionSet

    @jerelmiller
    jerelmiller committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    35374db View commit details
    Browse the repository at this point in the history

  3. Remove fragment sorting

    @jerelmiller
    jerelmiller committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d8ed107 View commit details
    Browse the repository at this point in the history

  4. Better handle change tracking when returning fragment spread

    @jerelmiller
    jerelmiller committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    8198a8f View commit details
    Browse the repository at this point in the history

  5. Remove unused code for accessor warnings

    @jerelmiller
    jerelmiller committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    1d2b3e4 View commit details
    Browse the repository at this point in the history

  6. Remove .failing on test

    @jerelmiller
    jerelmiller committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    1633ec4 View commit details
    Browse the repository at this point in the history

  7. Reenable all tests

    @jerelmiller
    jerelmiller committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    9240062 View commit details
    Browse the repository at this point in the history

  8. Remove unused import

    @jerelmiller
    jerelmiller committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    eec8ccc View commit details
    Browse the repository at this point in the history

  9. Use assignWithAccessors instead

    @jerelmiller
    jerelmiller committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    68ff5f0 View commit details
    Browse the repository at this point in the history

  10. Simplify assignWithAccessors

    @jerelmiller
    jerelmiller committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    f0d5c56 View commit details
    Browse the repository at this point in the history

  11. Fix incorrect test

    @jerelmiller
    jerelmiller committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    96a4977 View commit details
    Browse the repository at this point in the history

  12. Move assignment of value to end of logic

    @jerelmiller
    jerelmiller committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5dfeb94 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Ensure console mocks are cleared between checks

    @jerelmiller
    jerelmiller committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0496108 View commit details
    Browse the repository at this point in the history

  2. Ensure other properties are assigned with assignWithAccessors

    @jerelmiller
    jerelmiller committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    5f546b5 View commit details
    Browse the repository at this point in the history

  3. Minor refactor on descriptor

    @jerelmiller
    jerelmiller committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a7be4fb View commit details
    Browse the repository at this point in the history

  4. Set initialValue in iteration and return early when adding warning

    @jerelmiller
    jerelmiller committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    247cc75 View commit details
    Browse the repository at this point in the history

  5. Tweak test to check which fields warned

    @jerelmiller
    jerelmiller committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ad2f3f3 View commit details
    Browse the repository at this point in the history

  6. Add additional check for fields

    @jerelmiller
    jerelmiller committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    80b8233 View commit details
    Browse the repository at this point in the history

  7. Ensure value is set when assigning

    @jerelmiller
    jerelmiller committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a40589a View commit details
    Browse the repository at this point in the history

  8. add additional test

    @phryneas
    phryneas committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9ccb9ee View commit details
    Browse the repository at this point in the history