Pro 6810 search empty broken #4807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValJed
commented
Nov 19, 2024
| @@ -427,8 +427,6 @@ export default { | |||
| queryExtras.autocomplete = query; | |||
| } else if ('autocomplete' in this.queryExtras) { | |||
| queryExtras.autocomplete = undefined; | |||
| } else { | |||
| return {}; | |||
There was a problem hiding this comment.
The fix, in our case no autocomplete, we still want to perform the request.
myovchev
previously approved these changes
Nov 19, 2024
ValJed
force-pushed
the
pro-6810-search-empty-broken
branch
from
4776816
to
e8297c6
Compare
myovchev
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRO-6810
Summary
Performs the search even if the last is empty. Allows to reset the search to its initial state.
What are the specific steps to test this change?
Make search on pieces, them empty it, should work.
Cypress tests 🟢
What kind of change does this PR introduce?
Make sure the PR fulfills these requirements: