Remove obsolete websites with shared credential backend #397
Conversation
|
I think this is helping to show that we need a richer schema here. Some of these are historical entries, which can still be useful for offering cleanup on the client. @Cldfire, I think this is more fuel for the conversations we’ve been having about this. Really seems like we need a new, richer schema here, overall, which can express more types of relationships. |
|
Absolutely; these would all be a great fit for the format proposed in #389. I plan on getting around to updating the RFC with a format that more closely integrates with what exists today soon! |
|
This PR was opened for a while resulting into merge conflicts, so I have tried to address conflicts by updating PR with latest main, but it does not merge cleanly and fails websites-shared-credentials test. |
|
Closing this PR due to merge conflicts, please feel free to reopen this PR. |
There are quite a few domains which don't match the criteria. As started in the project README:
I'm guessing that these domains matched the criteria when they were added but the website maintainers have changed the behavior since then.
By that logic, the domains in this MR are removed for the following reasons.
alltrails.io redirects to alltrails.com
ameritrade.com redirects to tdameritrade.com
anylistapp.com redirects to anylist.com
capitalone360.com redirects to capitalone.com
citibankonline.com and citibank.com redirect to citi.com
comcast.net redirects to xfinity.com
discordapp.com redirects to discord.com
getdropbox.com redirects to dropbox.com
microsoft.com and skype.com use live.com SSO
office.com uses microsoftonline.com SSO
mojang.com redirects to minecraft.net
sonyentertainmentnetwork.com doesn't seem to exist anymore
square.com redirects to squareup.com
[z] I agree to the project's Developer Certificate of Origin
[z] The top-level JSON objects are sorted alphabetically
[z] There are no open pull requests for the same update