Add protonmail.com/protonmail.ch from shared credentials to proton.me #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you actually sign into the .ch website? I'm seeing it redirect to .com. |
|
Yes, if you specifically go to https://app.protonmail.ch. Should this be reflected in the files? |
Yes, I think so! |
|
Can this be merged? |
rmondello
approved these changes
Mar 9, 2022
Eitot
changed the title
rmondello
approved these changes
May 26, 2022
|
Looks like we have some tests failing. |
5 tasks
gracjankn
reviewed
Sep 4, 2024
|
This isn't your fault, @Eitot, but this data violates a constraint in our data format about overlapping rules. This is going to require more thought. |
protonmail.com and protonmail.ch are redirected to proton.me. protonvpn.com seems to be still used.
rmondello
pushed a commit
to rmondello/password-manager-resources
that referenced
this pull request
Nov 6, 2024
…apple#521) protonmail.com and protonmail.ch are redirected to proton.me. protonvpn.com seems to be still used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Checklist
for shared-credentials.json
shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use asharedassociation fromgoogle.co.iltogoogle.com, becausegoogle.co.ilredirects toaccounts.google.comfor sign in.)There is a support article on protonmail.com that explains the existence of the protonmail.ch domain for webmail logins: https://protonmail.com/support/knowledge-base/what-is-the-difference-between-protonmail-com-and-protonmail-ch/It seems that ProtonMail is migrating from protonmail.ch/protonmail.com to proton.me. app.protonmail.ch is redirected for me (status code 301). mail.protonmail.com seems to be still available, but a banner is shown at the top of the website. I have added both as
fromdomains and marked thefromDomainsAreObsoletedkey asfalse. protonvpn.com is still available.See also #378 for the reasons for adding protonvpn.com domain (the accounts are still connected).