Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added app.digiboxx.com in password-rules #748

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

amalgopal2015
Copy link
Contributor

@amalgopal2015 amalgopal2015 commented Feb 18, 2024

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

@amalgopal2015
Copy link
Contributor Author

Added app.digiboxx.com in password-rules

Screenshot 2024-02-19 020512

@rmondello
Copy link
Contributor

Hi @amalgopal2015! How did you come up with that list of special characters? Did the website list them, or did you try experimentally?

@kiddailey
Copy link
Contributor

I took a look at this by verifying each character individually (the site highlights when the requirement has been met) and the commit is not quite correct. The site requires at least one of the 0-8 number key symbols [!@#$%^&*]. The change submitted is missing the asterisk character.

The 9 and 0 key open and close parenthesis do NOT fulfill the symbol requirement. Nor do any of the other keyboard symbols ~`-_=+[{]}|;:'",<.>/? However, any of these symbols are allowed -- they just don't fulfill the requirement.

@dmmaslenn
Copy link
Collaborator

I have updated this PR to include special characters mentioned on the app.digiboxx.com sign up page:
Screenshot 2024-09-27 at 3 30 47 PM

@dmmaslenn dmmaslenn merged commit ae8e4ae into apple:main Sep 27, 2024
5 checks passed
rmondello pushed a commit to rmondello/password-manager-resources that referenced this pull request Nov 6, 2024
* Added app.digiboxx.com in password-rules

* Update password-rules.json

---------

Co-authored-by: Daria Maslennikova <35962122+dmmaslenn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants